src/compiler/ast-loop-assignment-analyzer.cc - Issue 1981323002: [compiler] Remove obsolete JSYield operator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ast-loop-assignment-analyzer.cc

Issue 1981323002: [compiler] Remove obsolete JSYield operator. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ast-loop-assignment-analyzer.cc

diff --git a/src/compiler/ast-loop-assignment-analyzer.cc b/src/compiler/ast-loop-assignment-analyzer.cc

index 334c5978a86f4088f80cb6af17d9b828980fae21..40898162518939bb93435f5dfe0dae02eec4444c 100644

--- a/src/compiler/ast-loop-assignment-analyzer.cc

+++ b/src/compiler/ast-loop-assignment-analyzer.cc

@@ -151,10 +151,7 @@ void ALAA::VisitObjectLiteral(ObjectLiteral* e) {

void ALAA::VisitArrayLiteral(ArrayLiteral* e) { VisitExpressions(e->values()); }

-void ALAA::VisitYield(Yield* stmt) {

- Visit(stmt->generator_object());

- Visit(stmt->expression());

+void ALAA::VisitYield(Yield* stmt) { UNREACHABLE(); }

Michael Starzinger 2016/05/17 15:49:32 Likewise, this runs before the AstGrpahBuilder, le

void ALAA::VisitThrow(Throw* stmt) { Visit(stmt->exception()); }