Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 1981323002: [compiler] Remove obsolete JSYield operator. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Remove obsolete JSYield operator. R=bmeurer@chromium.org BUG= Committed: https://crrev.com/75140f39dd7706927afe9ffd11a63954ac10591b Cr-Commit-Position: refs/heads/master@{#36312}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Reenable VisitYield #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -12 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-operator.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/unittests/compiler/js-operator-unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
neis
4 years, 7 months ago (2016-05-17 15:15:03 UTC) #1
Michael Starzinger
https://codereview.chromium.org/1981323002/diff/1/src/compiler/ast-graph-builder.cc File src/compiler/ast-graph-builder.cc (right): https://codereview.chromium.org/1981323002/diff/1/src/compiler/ast-graph-builder.cc#newcode2253 src/compiler/ast-graph-builder.cc:2253: void AstGraphBuilder::VisitYield(Yield* expr) { UNREACHABLE(); } As discussed offline: ...
4 years, 7 months ago (2016-05-17 15:49:32 UTC) #3
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-18 02:02:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981323002/20001
4 years, 7 months ago (2016-05-18 08:16:58 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 08:54:15 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 08:55:41 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/75140f39dd7706927afe9ffd11a63954ac10591b
Cr-Commit-Position: refs/heads/master@{#36312}

Powered by Google App Engine
This is Rietveld 408576698