Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1981313002: Fix ForwardingConstructorElementZ.computeEffectiveTargetType (Closed)

Created:
4 years, 7 months ago by Johnni Winther
Modified:
4 years, 7 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix ForwardingConstructorElementZ.computeEffectiveTargetType BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/bfb8a077e2e55964f65c3d4cb590c1e3f4ddc098

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/serialization/equivalence_test.dart View 1 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/serialization/helper.dart View 4 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
4 years, 7 months ago (2016-05-18 08:53:26 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1981313002/diff/1/tests/compiler/dart2js/serialization/equivalence_test.dart File tests/compiler/dart2js/serialization/equivalence_test.dart (right): https://codereview.chromium.org/1981313002/diff/1/tests/compiler/dart2js/serialization/equivalence_test.dart#newcode576 tests/compiler/dart2js/serialization/equivalence_test.dart:576: element1, element2, 'effectiveTargetType', maybe add `raw` somewhere in ...
4 years, 7 months ago (2016-05-19 16:42:21 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as bfb8a077e2e55964f65c3d4cb590c1e3f4ddc098 (presubmit successful).
4 years, 7 months ago (2016-05-20 09:20:34 UTC) #5
Johnni Winther
4 years, 7 months ago (2016-05-20 09:21:34 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/1981313002/diff/1/tests/compiler/dart2js/seri...
File tests/compiler/dart2js/serialization/equivalence_test.dart (right):

https://codereview.chromium.org/1981313002/diff/1/tests/compiler/dart2js/seri...
tests/compiler/dart2js/serialization/equivalence_test.dart:576: element1,
element2, 'effectiveTargetType',
On 2016/05/19 16:42:20, Siggi Cherem (dart-lang) wrote:
> maybe add `raw` somewhere in the string here to distinguish from the case
above?

Done.

Powered by Google App Engine
This is Rietveld 408576698