Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1981283005: cc : Delete Opacity/Transform/FilterIsAnimatingOnImplOnly (Closed)

Created:
4 years, 7 months ago by jaydasika
Modified:
4 years, 7 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc : Delete Opacity/Transform/FilterIsAnimatingOnImplOnly Because we do not support impl-only animations for these properties, these functions always return false and so we don't need them BUG=609205 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4d30f43b693d0060c9e3857e7d2ca7ce7981d120 Cr-Commit-Position: refs/heads/master@{#394279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M cc/layers/layer.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M cc/layers/layer_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
jaydasika
PTAL
4 years, 7 months ago (2016-05-17 22:04:24 UTC) #3
ajuma
lgtm, thanks for cleaning this up. Suggestion for follow-up: delete the (unused) remaining code in ...
4 years, 7 months ago (2016-05-17 23:15:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981283005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981283005/1
4 years, 7 months ago (2016-05-17 23:26:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 00:16:44 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 00:19:24 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d30f43b693d0060c9e3857e7d2ca7ce7981d120
Cr-Commit-Position: refs/heads/master@{#394279}

Powered by Google App Engine
This is Rietveld 408576698