Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1981273004: [Cleanup] Removed unused debugging code. (Closed)

Created:
4 years, 7 months ago by groby-ooo-7-16
Modified:
4 years, 7 months ago
Reviewers:
droger, mmenke
CC:
chromium-reviews, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Removed unused debugging code. The debugging CHECK removed here has been added in 2011, with a final comment of "More CHECKs are needed" on the bug, and no further updates since then. Looking at crash info, this does not seem to trigger in the wild. (Or if it does, at miniscule rates) BUG=102004 Committed: https://crrev.com/606a2ea600a2f7633db368a953a14eb30f0be59f Cr-Commit-Position: refs/heads/master@{#394623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -24 lines) Patch
M chrome/browser/profiles/profile_io_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 3 chunks +1 line, -9 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
groby-ooo-7-16
PTAL mmenke: ProfileIOData in general droger: ios side of things Thank you!
4 years, 7 months ago (2016-05-17 21:10:38 UTC) #3
mmenke
On 2016/05/17 21:10:38, groby wrote: > PTAL > > mmenke: ProfileIOData in general > droger: ...
4 years, 7 months ago (2016-05-17 21:13:22 UTC) #4
droger
lgtm
4 years, 7 months ago (2016-05-18 06:31:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981273004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981273004/1
4 years, 7 months ago (2016-05-18 22:55:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 01:06:23 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 01:08:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/606a2ea600a2f7633db368a953a14eb30f0be59f
Cr-Commit-Position: refs/heads/master@{#394623}

Powered by Google App Engine
This is Rietveld 408576698