Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1981153003: Allow multiprocess Dr Memory tests (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Allow multiprocess Dr Memory tests The Dr Memory tests currently run -j1 which makes corpus tests take a long time. Previously, multip-process corpus would override stdout which caused conflict when using Dr. Memory. That has been resolved so enable more parallelism. Committed: https://pdfium.googlesource.com/pdfium/+/dbc14facb99d7b6e9af5dd76f036b7bf59705b2f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M tools/drmemory/scripts/pdfium_tests.py View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dsinclair
PTAL. I'd like to give this a try to see if dr memory can use ...
4 years, 7 months ago (2016-05-17 16:38:19 UTC) #2
Oliver Chang
lgtm
4 years, 7 months ago (2016-05-17 16:38:58 UTC) #3
Tom Sepez
lgtm
4 years, 7 months ago (2016-05-17 16:41:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981153003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981153003/1
4 years, 7 months ago (2016-05-17 16:42:40 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 17:02:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/dbc14facb99d7b6e9af5dd76f036b7bf5970...

Powered by Google App Engine
This is Rietveld 408576698