Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1981093002: [Offline pages] Hooking up Archive Manager to Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@archive-manager
Patch Set: Fixing the windows bot Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_model_unittest.cc
diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc
index 3179a253a42b99f29b0ab0e30a58ae93bf473de9..62bb1a2920fa2fb4c3cc917d101906870bbd78ee 100644
--- a/components/offline_pages/offline_page_model_unittest.cc
+++ b/components/offline_pages/offline_page_model_unittest.cc
@@ -87,7 +87,6 @@ class OfflinePageModelTest
void OnGetMultipleOfflinePageItemsResult(
MultipleOfflinePageItemResult* storage,
const MultipleOfflinePageItemResult& result);
- void OnClearPageByStorageManager(int pages_cleared, DeletePageResult result);
// OfflinePageMetadataStore callbacks.
void OnStoreUpdateDone(bool /* success */);
@@ -388,13 +387,6 @@ void OfflinePageModelTest::OnGetMultipleOfflinePageItemsResult(
*storage = result;
}
-void OfflinePageModelTest::OnClearPageByStorageManager(
- int pages_cleared,
- DeletePageResult result) {
- last_cleared_pages_count_ = pages_cleared;
- last_clear_page_result_ = result;
-}
-
base::Optional<OfflinePageItem> OfflinePageModelTest::GetPagesByOnlineURL(
const GURL& online_url) {
MultipleOfflinePageItemResult result;
@@ -943,40 +935,6 @@ TEST_F(OfflinePageModelTest, SaveRetrieveMultipleClientIds) {
EXPECT_TRUE(id_set.find(offline2) != id_set.end());
}
-TEST_F(OfflinePageModelTest, ClearPagesFromOneSource) {
- base::Time now = base::Time::Now();
- base::TimeDelta expiration_period = model()
- ->GetPolicyController()
- ->GetPolicy(kTestClientNamespace)
- .lifetime_policy.expiration_period;
-
- SavePage(kTestUrl, kTestClientId1);
- GetStore()->UpdateLastAccessTime(
- last_save_offline_id(),
- now - base::TimeDelta::FromDays(10) - expiration_period);
- SavePage(kTestUrl2, kTestClientId2);
- GetStore()->UpdateLastAccessTime(
- last_save_offline_id(),
- now - base::TimeDelta::FromDays(1) - expiration_period);
- SavePage(kTestUrl3, kTestClientId3);
- GetStore()->UpdateLastAccessTime(last_save_offline_id(), now);
-
- ResetModel();
-
- // Only first two pages are expired.
- model()->GetStorageManager()->ClearPagesIfNeeded(base::Bind(
- &OfflinePageModelTest::OnClearPageByStorageManager, AsWeakPtr()));
-
- PumpLoop();
-
- std::vector<OfflinePageItem> offline_pages = GetAllPages();
-
- EXPECT_EQ(1UL, offline_pages.size());
- EXPECT_EQ(1UL, GetStore()->GetAllPages().size());
- EXPECT_EQ(2, last_cleared_pages_count());
- EXPECT_EQ(DeletePageResult::SUCCESS, last_clear_page_result());
-}
-
TEST_F(OfflinePageModelTest, GetBestPage) {
// We will save 3 pages - two for the same URL, and one for a different URL.
// Correct behavior will pick the most recently saved page for the correct
« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698