Added the --screenshot option.

build/android/pylib/local/device/local_device_instrumentation_test_run.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
+import os
 import re
 import time
 
 from devil.android import device_errors
 from devil.android import flag_changer
+from devil.android.device_utils import _GetTimeStamp

[BigBossZhiling, 2016/05/19 00:43:10]

If I just do, from devil.android import device_utils, and then call it by
'device_utils._GetTimeStamp()', presubmit checks will fail, saying calling
protected method blah blah blah.

[mikecase (-- gone --), 2016/05/19 00:49:27]

You should change the name to GetTimeStamp if you are going to use that
function.
The underscore is supposed to indicate that it is a private function.

But tbh, that GetTimeStamp function probably shouldnt be a public api in
device_utils since it doesnt get the time from the device or anything related to
teh device. You probably should move it somewhere in devil/utils/ when
making it public.

After you change the name you should change the import to just
from devil.android import device_utils

[jbudorick, 2016/05/19 18:11:42]

No, don't do this, and don't use _GetTimeStamp. Just do something similar to
what it does w/ strftime

[BigBossZhiling, 2016/05/19 18:23:49]

Done.

 from devil.utils import reraiser_thread
 from pylib import valgrind_tools
 from pylib.base import base_test_result
 from pylib.local.device import local_device_test_run
 
 
 TIMEOUT_ANNOTATIONS = [
   ('Manual', 10 * 60 * 60),
   ('IntegrationTest', 30 * 60),
   ('External', 10 * 60),
@@ skipping 235 matching lines @@
         if r.GetName() == test_name:
           r.SetName(test_display_name)
     if DidPackageCrashOnDevice(self._test_instance.test_package, device):
       for r in results:
         if r.GetType() == base_test_result.ResultType.UNKNOWN:
           r.SetType(base_test_result.ResultType.CRASH)
 
     if any(r.GetType() not in (base_test_result.ResultType.PASS,
                                base_test_result.ResultType.SKIP)
            for r in results):
+      if self._test_instance.screenshot_dir:
+        file_name = '%s-%s.png' % (test_display_name, _GetTimeStamp())
+        saved_dir = device.TakeScreenshot(
+          os.path.join(self._test_instance.screenshot_dir, file_name))
+        logging.info('Saved screenshot for %s to %s.',
+          test_display_name, saved_dir)
       logging.info('detected failure in %s. raw output:', test_display_name)
       for l in output:
         logging.info('  %s', l)
       if (not self._env.skip_clear_data
           and self._test_instance.package_info):
         permissions = (
             self._test_instance.apk_under_test.GetPermissions()
             if self._test_instance.apk_under_test
             else None)
         device.ClearApplicationState(self._test_instance.package_info.package,
@@ skipping 25 matching lines @@
         timeout = v
         break
     else:
       logging.warning('Using default 1 minute timeout for %s', test_name)
       timeout = 60
 
     timeout *= cls._GetTimeoutScaleFromAnnotations(annotations)
 
     return timeout