MD Settings: About page, implement help and feedback.

chrome/browser/resources/settings/about_page/about_page.js

Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index 677d7ff290eb5f8f8da6ec48bd8248019b7a4186..44da2984db37bcaad55952fe8a64205d4ebaae3e 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -21,6 +21,9 @@ Polymer({
     },
   },
 
+  /** @private {?settings.AboutPageBrowserProxy} */

[tommycli, 2016/05/17 00:36:48]

Was this supposed to be under properties?

[dpapad, 2016/05/17 00:45:13]

We have talked about this stylistic issue in a previous standup. Since this is
not used by HTML, there is no need to have it as a Polymer property. IIRC
correctly in the standup we said it is fine to put it either in "properties" or
outside. I have been using the "outside" approach in a few places, see
https://code.google.com/p/chromium/codesearch#search/&q=%22browserProxy_:%20n....

[tommycli, 2016/05/17 01:07:28]

Acknowledged.

+  browserProxy_: null,
+
   /**
    * @type {string} Selector to get the sections.
    * TODO(michaelpg): replace duplicate docs with @override once b/24294625
@@ -28,11 +31,21 @@ Polymer({
    */
   sectionSelector: 'settings-section',
 
+  /** @override */
+  ready: function() {
+    this.browserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
+  },
+
    /** @override */
   attached: function() {
     this.scroller = this.parentElement;
   },
 
+  /** @private */
+  onHelpTap_: function() {
+    this.browserProxy_.openHelpPage();
+  },
+
 <if expr="chromeos">
   /** @private */
   onDetailedBuildInfoTap_: function() {
@@ -41,4 +54,11 @@ Polymer({
     animatedPages.setSubpageChain(['detailed-build-info']);
   },
 </if>
+
+<if expr="_google_chrome">
+  /** @private */
+  onReportIssueTap_: function() {
+    this.browserProxy_.openFeedbackDialog();
+  },
+</if>
 });