Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3552)

Unified Diff: chrome/browser/resources/settings/about_page/about_page.js

Issue 1981033003: MD Settings: About page, implement help and feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak strings to match the mocks." Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/about_page/about_page.js
diff --git a/chrome/browser/resources/settings/about_page/about_page.js b/chrome/browser/resources/settings/about_page/about_page.js
index 677d7ff290eb5f8f8da6ec48bd8248019b7a4186..44da2984db37bcaad55952fe8a64205d4ebaae3e 100644
--- a/chrome/browser/resources/settings/about_page/about_page.js
+++ b/chrome/browser/resources/settings/about_page/about_page.js
@@ -21,6 +21,9 @@ Polymer({
},
},
+ /** @private {?settings.AboutPageBrowserProxy} */
+ browserProxy_: null,
+
/**
* @type {string} Selector to get the sections.
* TODO(michaelpg): replace duplicate docs with @override once b/24294625
@@ -28,11 +31,21 @@ Polymer({
*/
sectionSelector: 'settings-section',
+ /** @override */
+ ready: function() {
+ this.browserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
+ },
+
/** @override */
attached: function() {
this.scroller = this.parentElement;
},
+ /** @private */
+ onHelpTap_: function() {
+ this.browserProxy_.openHelpPage();
+ },
+
<if expr="chromeos">
/** @private */
onDetailedBuildInfoTap_: function() {
@@ -41,4 +54,11 @@ Polymer({
animatedPages.setSubpageChain(['detailed-build-info']);
},
</if>
+
+<if expr="_google_chrome">
+ /** @private */
+ onReportIssueTap_: function() {
+ this.browserProxy_.openFeedbackDialog();
+ },
+</if>
});

Powered by Google App Engine
This is Rietveld 408576698