MD Settings: About page, implement help and feedback.

chrome/test/data/webui/settings/about_page_tests.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings_about_page', function() {
   /**
    * @constructor
    * @implements {settings.AboutPageBrowserProxy}
    * @extends {settings.TestBrowserProxy}
    */
   var TestAboutPageBrowserProxy = function() {
     settings.TestBrowserProxy.call(this, [
-      'refreshUpdateStatus',
       'getCurrentChannel',
       'getVersionInfo',
+      'openFeedbackDialog',

[tommycli, 2016/05/17 00:36:48]

nit: Can we make this match the interface order?

[dpapad, 2016/05/17 00:45:13]

Done.

+      'openHelpPage',
+      'refreshUpdateStatus',
     ]);
 
     /** @type {!VersionInfo} */
     this.versionInfo_ = {
       arcVersion: '',
       osFirmware: '',
       osVersion: '',
     };
   };
 
@@ skipping 14 matching lines @@
     getCurrentChannel: function() {
       this.methodCalled('getCurrentChannel');
       return Promise.resolve(BrowserChannel.BETA);
     },
 
     /** @override */
     getVersionInfo: function() {
       this.methodCalled('getVersionInfo');
       return Promise.resolve(this.versionInfo_);
     },
+
+    /** @override */
+    openFeedbackDialog: function() {
+      this.methodCalled('openFeedbackDialog');
+    },
+
+    /** @override */
+    openHelpPage: function() {
+      this.methodCalled('openHelpPage');
+    },
   };
 
   function registerAboutPageTests() {
-      suite('AboutPageTest', function() {
-        test('Initialization', function() {
-          // TODO(dpapad): Implement this test once <settings-about-page> is
-          // ready. Currently this is needed to avoid failing with
-          // "Failure: Mocha ran, but no mocha tests were run!" on non-ChromeOS
-          // test bots.
-        });
+    suite('AboutPageTest', function() {
+      var page = null;
+      var browserProxy = null;
+
+      setup(function() {
+        browserProxy = new TestAboutPageBrowserProxy();
+        settings.AboutPageBrowserProxyImpl.instance_ = browserProxy;
+        PolymerTest.clearBody();
+        page = document.createElement('settings-about-page');
+        document.body.appendChild(page);
       });
+
+      test('GetHelp', function() {
+        assertTrue(!!page.$.help);
+        MockInteractions.tap(page.$.help);
+        return browserProxy.whenCalled('openHelpPage');
+      });
+    });
+  }
+
+  function registerOfficialBuildTests() {
+    suite('AboutPageTest_OfficialBuild', function() {
+      var page = null;
+      var browserProxy = null;
+
+      setup(function() {
+        browserProxy = new TestAboutPageBrowserProxy();
+        settings.AboutPageBrowserProxyImpl.instance_ = browserProxy;
+        PolymerTest.clearBody();
+        page = document.createElement('settings-about-page');
+        document.body.appendChild(page);
+      });
+
+      test('ReportAnIssue', function() {
+        assertTrue(!!page.$.reportIssue);
+        MockInteractions.tap(page.$.reportIssue);
+        return browserProxy.whenCalled('openFeedbackDialog');
+      });
+    });
   }
 
   if (cr.isChromeOS) {
     function registerDetailedBuildInfoTests() {
       suite('DetailedBuildInfoTest', function() {
         var page = null;
         var browserProxy = null;
 
         setup(function() {
           browserProxy = new TestAboutPageBrowserProxy();
@@ skipping 28 matching lines @@
     }
   }
 
   return {
     registerTests: function() {
       if (cr.isChromeOS) {
         registerDetailedBuildInfoTests();
       }
       registerAboutPageTests();
     },
+    registerOfficialBuildTests: registerOfficialBuildTests,
   };
 });