MD Settings: About page, implement help and feedback.

chrome/browser/resources/settings/about_page/about_page.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-about-page' contains version and OS related
  * information.
  */
 Polymer({
   is: 'settings-about-page',
 
   behaviors: [RoutableBehavior],
 
   properties: {
     /**
      * The current active route.
      */
     currentRoute: {
       type: Object,
       notify: true,
     },
   },
 
+  /** @private {?settings.AboutPageBrowserProxy} */

[tommycli, 2016/05/17 00:36:48]

Was this supposed to be under properties?

[dpapad, 2016/05/17 00:45:13]

We have talked about this stylistic issue in a previous standup. Since this is
not used by HTML, there is no need to have it as a Polymer property. IIRC
correctly in the standup we said it is fine to put it either in "properties" or
outside. I have been using the "outside" approach in a few places, see
https://code.google.com/p/chromium/codesearch#search/&q=%22browserProxy_:%20n....

[tommycli, 2016/05/17 01:07:28]

Acknowledged.

+  browserProxy_: null,
+
   /**
    * @type {string} Selector to get the sections.
    * TODO(michaelpg): replace duplicate docs with @override once b/24294625
    * is fixed.
    */
   sectionSelector: 'settings-section',
 
+  /** @override */
+  ready: function() {
+    this.browserProxy_ = settings.AboutPageBrowserProxyImpl.getInstance();
+  },
+
    /** @override */
   attached: function() {
     this.scroller = this.parentElement;
   },
 
+  /** @private */
+  onHelpTap_: function() {
+    this.browserProxy_.openHelpPage();
+  },
+
 <if expr="chromeos">
   /** @private */
   onDetailedBuildInfoTap_: function() {
     var animatedPages = /** @type {!SettingsAnimatedPagesElement} */ (
         this.$.pages);
     animatedPages.setSubpageChain(['detailed-build-info']);
   },
 </if>
+
+<if expr="_google_chrome">
+  /** @private */
+  onReportIssueTap_: function() {
+    this.browserProxy_.openFeedbackDialog();
+  },
+</if>
 });