Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 198103012: Remove --shallow from git cache call in gclient (Closed)

Created:
6 years, 9 months ago by Ryan Tseng
Modified:
6 years, 9 months ago
Reviewers:
agable, iannucci, hinoka
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove --shallow from git cache call in gclient We don't want to do a shallow clone into the cache because it is not supported on versions of git older than 1.9. BUG=261741 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=257578

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M gclient_scm.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hinoka
The failure mode of the "fatal: attempt to fetch/clone from a shallow repository" bug is ...
6 years, 9 months ago (2014-03-14 02:13:25 UTC) #1
agable
lgtm
6 years, 9 months ago (2014-03-18 01:52:21 UTC) #2
Ryan Tseng
The CQ bit was checked by hinoka@google.com
6 years, 9 months ago (2014-03-18 02:09:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hinoka@google.com/198103012/1
6 years, 9 months ago (2014-03-18 02:09:06 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-18 02:10:40 UTC) #5
Message was sent while issue was closed.
Change committed as 257578

Powered by Google App Engine
This is Rietveld 408576698