Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: pkg/barback/test/transformer_test.dart

Issue 198103003: Support extensions with multiple periods in Transformer.allowedExtensions. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/barback/lib/src/transformer.dart ('K') | « pkg/barback/lib/src/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/test/transformer_test.dart
diff --git a/pkg/barback/test/transformer_test.dart b/pkg/barback/test/transformer_test.dart
index 9df3f4ab6bd72ed3c7824d5472569788c0acc5ed..902e140918511d0259742cb8b8fb1bfc73ee88ae 100644
--- a/pkg/barback/test/transformer_test.dart
+++ b/pkg/barback/test/transformer_test.dart
@@ -27,6 +27,19 @@ main() {
completion(isFalse));
});
+ test("supports multi-level extensions with allowedExtensions", () {
+ var transformer = new ExtensionTransformer(".dart.js");
+ expect(transformer.isPrimary(makeAsset("foo.dart.js")),
+ completion(isTrue));
+
+ expect(transformer.isPrimary(makeAsset("foo.js")), completion(isFalse));
+ expect(transformer.isPrimary(makeAsset("foo.dart")), completion(isFalse));
+ });
+
+ test("throws an error for extensions without periods", () {
+ expect(() => new ExtensionTransformer("dart"), throwsFormatException);
+ });
+
test("allows all files if allowedExtensions is not overridden", () {
var transformer = new MockTransformer();
expect(transformer.isPrimary(makeAsset("foo.txt")),
« pkg/barback/lib/src/transformer.dart ('K') | « pkg/barback/lib/src/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698