Replace Release() { delete this; } in fde_xml_imp.h

xfa/fde/xml/fde_xml_imp.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fde/xml/fde_xml_imp.h"
 
 #include <algorithm>
 
@@ skipping 59 matching lines @@
     }
   }
   return FALSE;
 }
 
 CFDE_XMLNode::CFDE_XMLNode()
     : m_pParent(NULL), m_pChild(NULL), m_pPrior(NULL), m_pNext(NULL) {}
 CFDE_XMLNode::~CFDE_XMLNode() {
   DeleteChildren();
 }
+
 void CFDE_XMLNode::DeleteChildren() {
-  CFDE_XMLNode *pChild = m_pChild, *pTemp;
-  while (pChild != NULL) {
-    pTemp = pChild->m_pNext;
-    pChild->Release();
-    pChild = pTemp;
+  CFDE_XMLNode* pChild = m_pChild;
+  while (pChild) {
+    CFDE_XMLNode* pNext = pChild->m_pNext;
+    delete pChild;
+    pChild = pNext;
   }
-  m_pChild = NULL;
+  m_pChild = nullptr;
 }
+
 int32_t CFDE_XMLNode::CountChildNodes() const {
   int32_t iCount = 0;
   CFDE_XMLNode* pChild = m_pChild;
   while (pChild != NULL) {
     iCount++;
     pChild = pChild->m_pNext;
   }
   return iCount;
 }
 CFDE_XMLNode* CFDE_XMLNode::GetChildNode(int32_t index) const {
@@ skipping 754 matching lines @@
 void CFDE_XMLDoc::Reset(FX_BOOL bInitRoot) {
   m_iStatus = 0;
   m_pStream = NULL;
   if (bInitRoot) {
     if (m_pRoot == NULL) {
       m_pRoot = new CFDE_XMLNode;
     } else {
       m_pRoot->DeleteChildren();
     }
   } else {
-    if (m_pRoot != NULL) {
-      m_pRoot->Release();
-      m_pRoot = NULL;
-    }
+    delete m_pRoot;
+    m_pRoot = nullptr;
   }
   ReleaseParser();
 }
+
 void CFDE_XMLDoc::ReleaseParser() {
-  if (m_pXMLParser != NULL) {
-    m_pXMLParser->Release();
-    m_pXMLParser = NULL;
-  }
-  if (m_pSyntaxParser != NULL) {
-    m_pSyntaxParser->Release();
-    m_pSyntaxParser = NULL;
-  }
+  delete m_pXMLParser;
+  m_pXMLParser = nullptr;
+  delete m_pSyntaxParser;
+  m_pSyntaxParser = nullptr;
 }
+
 FX_BOOL CFDE_XMLDoc::LoadXML(IFX_Stream* pXMLStream,
                              int32_t iXMLPlaneSize,
                              int32_t iTextDataSize,
                              FDE_XMLREADERHANDLER* pHandler) {
   if (pXMLStream == NULL) {
     return FALSE;
   }
   Reset(TRUE);
   iXMLPlaneSize = iXMLPlaneSize / 1024;
   if (iXMLPlaneSize < 1) {
@@ skipping 1183 matching lines @@
     m_BlockBuffer.DeleteTextChars(m_iDataLength - m_iEntityStart, FALSE);
     m_pCurrentBlock = m_BlockBuffer.GetAvailableBlock(m_iIndexInBlock);
     m_iEntityStart = -1;
   } else {
     if (m_iEntityStart < 0 && ch == L'&') {
       m_iEntityStart = m_iDataLength - 1;
     }
   }
   m_pStart++;
 }