Convert border style defines to an enum class.

Convert border style defines to an enum class.

There were two defines, BBS_ and PBS_ for the various border styles in the
system. They were the same, except PBS_ had an extra SHADOW define which was
never used.

This CL combines both of those into a single BorderStyle enum class and updates
the code as needed.

Also, removes ADDBIT, GETBIT unused defines. Updates barcode code to use
the util.h defines instead of redefinition. fsdk_baseannot names starting with _ were cleaned up and some #defines moved to constants.

Committed: https://pdfium.googlesource.com/pdfium/+/92cb5e580cecf0412b74d51e8863ed557e2bd47a

[dsinclair, 2016-05-16 18:04:23]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-16 18:04:24]

PTAL.

https://codereview.chromium.org/1980973002/diff/1/fpdfsdk/pdfwindow/PWL_Utils...
File fpdfsdk/pdfwindow/PWL_Utils.cpp (left):

https://codereview.chromium.org/1980973002/diff/1/fpdfsdk/pdfwindow/PWL_Utils...
fpdfsdk/pdfwindow/PWL_Utils.cpp:1441: case PBS_SHADOW: {
We never assigned a value of _SHADOW, so removed.

https://codereview.chromium.org/1980973002/diff/1/xfa/fwl/basewidget/fxmath_b...
File xfa/fwl/basewidget/fxmath_barcodeimp.cpp (left):

https://codereview.chromium.org/1980973002/diff/1/xfa/fwl/basewidget/fxmath_b...
xfa/fwl/basewidget/fxmath_barcodeimp.cpp:324: #define BCExceptionNO 0
These are all defined in fxbarcode/utils.h

[Tom Sepez, 2016-05-16 18:17:55]

LGTM, but also itemize the few unrelated changes in the CL description, e.g. the
removal of _, etc.

https://codereview.chromium.org/1980973002/diff/1/core/fxcodec/codec/fx_codec...
File core/fxcodec/codec/fx_codec_fax.cpp (left):

https://codereview.chromium.org/1980973002/diff/1/core/fxcodec/codec/fx_codec...
core/fxcodec/codec/fx_codec_fax.cpp:135: #define ADDBIT(code, bit) \
unrelated change, but ok.

[dsinclair, 2016-05-16 18:37:55]

Description was changed from

==========
Convert border style defines to an enum class.

There were two defines, BBS_ and PBS_ for the various border styles in the
system. They were the same, except PBS_ had an extra SHADOW define which was
never used.

This CL combines both of those into a single BorderStyle enum class and updates
the code as needed.
==========

to

==========
Convert border style defines to an enum class.

There were two defines, BBS_ and PBS_ for the various border styles in the
system. They were the same, except PBS_ had an extra SHADOW define which was
never used.

This CL combines both of those into a single BorderStyle enum class and updates
the code as needed.

Also, removes ADDBIT, GETBIT unused defines. Updates barcode code to use
the util.h defines instead of redefinition. fsdk_baseannot names starting with _
were cleaned up and some #defines moved to constants.
==========

[dsinclair, 2016-05-16 18:38:03]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-05-16 18:38:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980973002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980973002/1

[commit-bot: I haz the power, 2016-05-16 18:38:32]

Description was changed from

==========
Convert border style defines to an enum class.

There were two defines, BBS_ and PBS_ for the various border styles in the
system. They were the same, except PBS_ had an extra SHADOW define which was
never used.

This CL combines both of those into a single BorderStyle enum class and updates
the code as needed.

Also, removes ADDBIT, GETBIT unused defines. Updates barcode code to use
the util.h defines instead of redefinition. fsdk_baseannot names starting with _
were cleaned up and some #defines moved to constants.
==========

to

==========
Convert border style defines to an enum class.

There were two defines, BBS_ and PBS_ for the various border styles in the
system. They were the same, except PBS_ had an extra SHADOW define which was
never used.

This CL combines both of those into a single BorderStyle enum class and updates
the code as needed.

Also, removes ADDBIT, GETBIT unused defines. Updates barcode code to use
the util.h defines instead of redefinition. fsdk_baseannot names starting with _
were cleaned up and some #defines moved to constants.

Committed:
https://pdfium.googlesource.com/pdfium/+/92cb5e580cecf0412b74d51e8863ed557e2b...
==========

[commit-bot: I haz the power, 2016-05-16 18:38:33]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/92cb5e580cecf0412b74d51e8863ed557e2b...