Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1980963002: Remove unsupported libraries from `libraries.dart`. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove unsupported libraries from `libraries.dart`. These libraries are not supported by dev_compiler, hence the source files that declare them don't exist in tool/input_sdk/lib. Removing them from `libraries.dart` will allow the analyzer to build a summary of dev_compiler's fork of the SDK. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f90653267b18bcaa56daee2cd3e0b9a1e1b0e339

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -28 lines) Patch
M tool/input_sdk/lib/_internal/libraries.dart View 3 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-16 17:47:44 UTC) #2
vsm
lgtm
4 years, 7 months ago (2016-05-16 17:55:30 UTC) #3
Paul Berry
4 years, 7 months ago (2016-05-16 18:19:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f90653267b18bcaa56daee2cd3e0b9a1e1b0e339 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698