Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1980913003: S390: Added 96 new instructions to the simulator EVALUATE code. (Closed)

Created:
4 years, 7 months ago by bcleung
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Added 96 new instructions to the simulator EVALUATE code. R=joransiu@ca.ibm.com,michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,jyan@ca.ibm.com BUG= Committed: https://crrev.com/ef006c42575e86d6acd51976ce9a4ad3b7461e85 Cr-Commit-Position: refs/heads/master@{#36297}

Patch Set 1 #

Patch Set 2 : Added DCHECKs #

Patch Set 3 : Switched to using decode macros #

Total comments: 1

Patch Set 4 : Removed the "instructions not implemented" comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1258 lines, -116 lines) Patch
M src/s390/simulator-s390.cc View 1 2 3 20 chunks +1258 lines, -116 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
JoranSiu
lgtm https://codereview.chromium.org/1980913003/diff/40001/src/s390/simulator-s390.cc File src/s390/simulator-s390.cc (right): https://codereview.chromium.org/1980913003/diff/40001/src/s390/simulator-s390.cc#newcode7203 src/s390/simulator-s390.cc:7203: // IIHH, IIHL, IILH, IILL are unimplemented Let's ...
4 years, 7 months ago (2016-05-17 21:50:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980913003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980913003/60001
4 years, 7 months ago (2016-05-17 22:29:51 UTC) #4
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-17 22:57:01 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 22:59:04 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ef006c42575e86d6acd51976ce9a4ad3b7461e85
Cr-Commit-Position: refs/heads/master@{#36297}

Powered by Google App Engine
This is Rietveld 408576698