Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1980903002: Passing fast/media/media-svg-crash.html (Closed)

Created:
4 years, 7 months ago by chakshu
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, dstockwell
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Passing fast/media/media-svg-crash.html BUG=441705 Committed: https://crrev.com/882a0d56956f13092af1b5167c29e7b7d538593b Cr-Commit-Position: refs/heads/master@{#394746}

Patch Set 1 #

Patch Set 2 : Removed change to expected file #

Patch Set 3 : Made change in the expected file in win platform #

Patch Set 4 : Updated the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/fast/media/media-svg-crash-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 25 (12 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980903002/1
4 years, 7 months ago (2016-05-16 06:28:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/229345)
4 years, 7 months ago (2016-05-16 07:31:55 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980903002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980903002/20001
4 years, 7 months ago (2016-05-16 09:28:19 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/222208)
4 years, 7 months ago (2016-05-16 11:01:27 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980903002/40001
4 years, 7 months ago (2016-05-18 11:04:59 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 12:17:25 UTC) #12
chakshu
Kindly review this fix.
4 years, 7 months ago (2016-05-18 12:23:53 UTC) #14
Dirk Pranke
lgtm
4 years, 7 months ago (2016-05-18 15:33:40 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980903002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980903002/40001
4 years, 7 months ago (2016-05-19 05:25:48 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/186212)
4 years, 7 months ago (2016-05-19 05:33:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980903002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980903002/60001
4 years, 7 months ago (2016-05-19 10:17:10 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-19 12:16:06 UTC) #23
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 12:17:38 UTC) #25
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/882a0d56956f13092af1b5167c29e7b7d538593b
Cr-Commit-Position: refs/heads/master@{#394746}

Powered by Google App Engine
This is Rietveld 408576698