third_party/WebKit/Source/core/page/DragController.cpp - Issue 1980893002: Remove OwnPtr::release() calls in core/ (part 4).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/DragController.cpp

Issue 1980893002: Remove OwnPtr::release() calls in core/ (part 4). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp ('k') | third_party/WebKit/Source/core/page/scrolling/ScrollState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/DragController.cpp

diff --git a/third_party/WebKit/Source/core/page/DragController.cpp b/third_party/WebKit/Source/core/page/DragController.cpp

index 756212816c5b57f89b06d0f720193857c271ec90..aaaa83f6960b2fdf436e6cdf8e47147aaa787e8f 100644

--- a/third_party/WebKit/Source/core/page/DragController.cpp

+++ b/third_party/WebKit/Source/core/page/DragController.cpp

@@ -831,7 +831,7 @@ static PassOwnPtr<DragImage> dragImageForImage(Element* element, Image* image, f

}

dragLocation = dragOrigin + origin;

- return dragImage.release();

+ return dragImage;

}

static PassOwnPtr<DragImage> dragImageForLink(const KURL& linkURL, const String& linkText, float deviceScaleFactor, const IntPoint& mouseDraggedPoint, IntPoint& dragLoc)

@@ -844,7 +844,7 @@ static PassOwnPtr<DragImage> dragImageForLink(const KURL& linkURL, const String&

IntPoint dragImageOffset(-size.width() / 2, -LinkDragBorderInset);

dragLoc = IntPoint(mouseDraggedPoint.x() + dragImageOffset.x(), mouseDraggedPoint.y() + dragImageOffset.y());

- return dragImage.release();

+ return dragImage;

}

bool DragController::startDrag(LocalFrame* src, const DragState& state, const PlatformMouseEvent& dragEvent, const IntPoint& dragOrigin)