Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1980833002: Reduce Error Message in LoginDisplayHostImpl::ShutdownDisplayHost (Closed)

Created:
4 years, 7 months ago by jonross
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce Error Message in LoginDisplayHostImpl::ShutdownDisplayHost The NOTIMPLEMENTED for Mus in LoginDisplayHostImpl::ShutdownDisplayHost was too aggressive, and triggering in vm_tests for non-Mus builds. Restricting the NOTIMPLEMENTED to just the Mus scenario BUG=611580 Committed: https://crrev.com/7c4480dca0af49887343705b1776ee01bb3cab19 Cr-Commit-Position: refs/heads/master@{#393919}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jonross
Hey sky@ In this change I make a NOTIMPLEMENTED message restricted to just Mus. It ...
4 years, 7 months ago (2016-05-16 16:36:59 UTC) #2
sky
LGTM
4 years, 7 months ago (2016-05-16 19:35:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980833002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980833002/20001
4 years, 7 months ago (2016-05-16 20:01:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-16 21:10:32 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 21:12:16 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7c4480dca0af49887343705b1776ee01bb3cab19
Cr-Commit-Position: refs/heads/master@{#393919}

Powered by Google App Engine
This is Rietveld 408576698