components/nacl/common/nacl_messages.h - Issue 198083006: Update the task manager with the debug stub port chosen by nacl.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/nacl/common/nacl_messages.h

Issue 198083006: Update the task manager with the debug stub port chosen by nacl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« components/nacl/browser/nacl_process_host.cc ('K') | « components/nacl/browser/nacl_process_host.cc ('k') | components/nacl/loader/nacl_listener.cc » ('j') | components/nacl/loader/nacl_listener.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Defines messages between the browser and NaCl process.	5 // Defines messages between the browser and NaCl process.

6	6

7 // Multiply-included message file, no traditional include guard.	7 // Multiply-included message file, no traditional include guard.

8 #include "base/process/process.h"	8 #include "base/process/process.h"

9 #include "components/nacl/common/nacl_types.h"	9 #include "components/nacl/common/nacl_types.h"

10 #include "ipc/ipc_channel_handle.h"	10 #include "ipc/ipc_channel_handle.h"

(...skipping 77 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
88 IPC::PlatformFileForTransit, /* fd */	88 IPC::PlatformFileForTransit, /* fd */

89 base::FilePath /* Path opened to get fd */)	89 base::FilePath /* Path opened to get fd */)

90	90

91 // Notify the browser process that the server side of the PPAPI channel was	91 // Notify the browser process that the server side of the PPAPI channel was

92 // created successfully.	92 // created successfully.

93 IPC_MESSAGE_CONTROL4(NaClProcessHostMsg_PpapiChannelsCreated,	93 IPC_MESSAGE_CONTROL4(NaClProcessHostMsg_PpapiChannelsCreated,

94 IPC::ChannelHandle, /* browser_channel_handle */	94 IPC::ChannelHandle, /* browser_channel_handle */

95 IPC::ChannelHandle, /* ppapi_renderer_channel_handle */	95 IPC::ChannelHandle, /* ppapi_renderer_channel_handle */

96 IPC::ChannelHandle, /* trusted_renderer_channel_handle */	96 IPC::ChannelHandle, /* trusted_renderer_channel_handle */

97 IPC::ChannelHandle /* manifest_service_channel_handle */)	97 IPC::ChannelHandle /* manifest_service_channel_handle */)

	98

	99 // Notify the browser process that the debug stub port has been selected.
	Mark Seaborn 2014/05/08 15:52:23 How about "Notify the browser process that the NaC How about "Notify the browser process that the NaCl process has bound the given TCP port number to use for the GDB debug stub". (i.e. Avoid passive voice; mention GDB and TCP for context.) bradn 2014/05/08 17:00:24 Done. Show quoted text On 2014/05/08 15:52:23, Mark Seaborn wrote: > How about "Notify the browser process that the NaCl process has bound the given > TCP port number to use for the GDB debug stub". (i.e. Avoid passive voice; > mention GDB and TCP for context.) Done.
	100 IPC_MESSAGE_CONTROL1(NaClProcessHostMsg_DebugStubPortSelected,
	Mark Seaborn 2014/05/08 15:52:23 This can be conditionalised on OS_WIN, and go afte This can be conditionalised on OS_WIN, and go after AttachDebugExceptionHandler. bradn 2014/05/08 17:00:24 Done. Show quoted text On 2014/05/08 15:52:23, Mark Seaborn wrote: > This can be conditionalised on OS_WIN, and go after AttachDebugExceptionHandler. Done.
	101 uint16_t /* debug_stub_port */)

OLD	NEW