Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: net/quic/quic_connection.h

Issue 1980783002: Only set one QUIC sending alarm at once. Flag protected by --quic_only_one_sending_alarm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@121671674
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // The entity that handles framing writes for a Quic client or server. 5 // The entity that handles framing writes for a Quic client or server.
6 // Each QuicSession will have a connection associated with it. 6 // Each QuicSession will have a connection associated with it.
7 // 7 //
8 // On the server side, the Dispatcher handles the raw reads, and hands off 8 // On the server side, the Dispatcher handles the raw reads, and hands off
9 // packets via ProcessUdpPacket for framing and processing. 9 // packets via ProcessUdpPacket for framing and processing.
10 // 10 //
(...skipping 948 matching lines...) Expand 10 before | Expand all | Expand 10 after
959 959
960 // An alarm that fires when an ACK should be sent to the peer. 960 // An alarm that fires when an ACK should be sent to the peer.
961 QuicArenaScopedPtr<QuicAlarm> ack_alarm_; 961 QuicArenaScopedPtr<QuicAlarm> ack_alarm_;
962 // An alarm that fires when a packet needs to be retransmitted. 962 // An alarm that fires when a packet needs to be retransmitted.
963 QuicArenaScopedPtr<QuicAlarm> retransmission_alarm_; 963 QuicArenaScopedPtr<QuicAlarm> retransmission_alarm_;
964 // An alarm that is scheduled when the SentPacketManager requires a delay 964 // An alarm that is scheduled when the SentPacketManager requires a delay
965 // before sending packets and fires when the packet may be sent. 965 // before sending packets and fires when the packet may be sent.
966 QuicArenaScopedPtr<QuicAlarm> send_alarm_; 966 QuicArenaScopedPtr<QuicAlarm> send_alarm_;
967 // An alarm that is scheduled when the connection can still write and there 967 // An alarm that is scheduled when the connection can still write and there
968 // may be more data to send. 968 // may be more data to send.
969 // TODO(ianswett): Remove resume_writes_alarm when deprecating
970 // FLAGS_quic_only_one_sending_alarm
969 QuicArenaScopedPtr<QuicAlarm> resume_writes_alarm_; 971 QuicArenaScopedPtr<QuicAlarm> resume_writes_alarm_;
970 // An alarm that fires when the connection may have timed out. 972 // An alarm that fires when the connection may have timed out.
971 QuicArenaScopedPtr<QuicAlarm> timeout_alarm_; 973 QuicArenaScopedPtr<QuicAlarm> timeout_alarm_;
972 // An alarm that fires when a ping should be sent. 974 // An alarm that fires when a ping should be sent.
973 QuicArenaScopedPtr<QuicAlarm> ping_alarm_; 975 QuicArenaScopedPtr<QuicAlarm> ping_alarm_;
974 // An alarm that fires when an MTU probe should be sent. 976 // An alarm that fires when an MTU probe should be sent.
975 QuicArenaScopedPtr<QuicAlarm> mtu_discovery_alarm_; 977 QuicArenaScopedPtr<QuicAlarm> mtu_discovery_alarm_;
976 978
977 // Neither visitor is owned by this class. 979 // Neither visitor is owned by this class.
978 QuicConnectionVisitorInterface* visitor_; 980 QuicConnectionVisitorInterface* visitor_;
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 1059
1058 // If true, multipath is enabled for this connection. 1060 // If true, multipath is enabled for this connection.
1059 bool multipath_enabled_; 1061 bool multipath_enabled_;
1060 1062
1061 DISALLOW_COPY_AND_ASSIGN(QuicConnection); 1063 DISALLOW_COPY_AND_ASSIGN(QuicConnection);
1062 }; 1064 };
1063 1065
1064 } // namespace net 1066 } // namespace net
1065 1067
1066 #endif // NET_QUIC_QUIC_CONNECTION_H_ 1068 #endif // NET_QUIC_QUIC_CONNECTION_H_
OLDNEW
« no previous file with comments | « no previous file | net/quic/quic_connection.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698