Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py

Issue 1980773002: [BattOr][Telemetry] Changes needed to run BattOr tests on telemetry. (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py
diff --git a/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py b/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py
index f91903403b3826bb9ede891e662397ef77d0c065..3a14785807e9fd1fc21154d5643aba6002da7a8a 100644
--- a/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py
+++ b/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent_unittest.py
@@ -6,6 +6,7 @@ import unittest
from battor import battor_error
from battor import battor_wrapper
+from devil.android import battery_utils
from telemetry.internal.platform.tracing_agent import battor_tracing_agent
from telemetry.timeline import trace_data
from telemetry.timeline import tracing_config
@@ -13,6 +14,18 @@ from telemetry.timeline import tracing_config
_BATTOR_RETURN = ['fake', 'battor', 'data']
+class FakeBatteryUtils(object):
+ def __init__(self, device):
+ self._device = device
+ self._charging_state = True
+
+ def SetCharging(self, state):
+ self._charging_state = state
+
+ def GetCharging(self):
+ return self._charging_state
+
+
class FakePlatformBackend(object):
def GetOSName(self):
return ''
@@ -83,6 +96,9 @@ class BattOrTracingAgentTest(unittest.TestCase):
battor_wrapper.BattorWrapper = FakeBattOr
battor_wrapper.IsBattOrConnected = lambda x, android_device=None: True
+ self._battery_utils = battery_utils.BatteryUtils
+ battery_utils.BatteryUtils = FakeBatteryUtils
+
# Agents and backends.
self.android_backend = FakeAndroidPlatformBackend()
self.desktop_backend = FakeDesktopPlatformBackend()
@@ -152,7 +168,14 @@ class BattOrTracingAgentTest(unittest.TestCase):
builder = builder.AsData()
self.assertTrue(builder.HasEventsFor(trace_data.BATTOR_TRACE_PART))
data_from_builder = builder.GetEventsFor(trace_data.BATTOR_TRACE_PART)
- self.assertListEqual(['\n'.join(_BATTOR_RETURN)], data_from_builder)
+ self.assertEqual('\n'.join(_BATTOR_RETURN), data_from_builder)
+
+ def testAndroidCharging(self):
+ self.assertTrue(self.android_agent._battery.GetCharging())
+ self.assertTrue(self.android_agent.StartAgentTracing(self._config, 0))
+ self.assertFalse(self.android_agent._battery.GetCharging())
+ self.android_agent.StopAgentTracing()
+ self.assertTrue(self.android_agent._battery.GetCharging())
def testRecordClockSyncMarker(self):
def callback_with_exception(a, b):

Powered by Google App Engine
This is Rietveld 408576698