Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Unified Diff: chrome/browser/chrome_browser_field_trials_desktop.cc

Issue 1980743002: Track thread activities in order to diagnose hangs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@readwrite-mmf
Patch Set: rebased Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/threading/platform_thread_win.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_field_trials_desktop.cc
diff --git a/chrome/browser/chrome_browser_field_trials_desktop.cc b/chrome/browser/chrome_browser_field_trials_desktop.cc
index 3fde8ad4b524851eddffc7a521768ba1b227c1bf..b955ed8ac5150a4e67dea4c5f76f37e1490db510 100644
--- a/chrome/browser/chrome_browser_field_trials_desktop.cc
+++ b/chrome/browser/chrome_browser_field_trials_desktop.cc
@@ -7,8 +7,12 @@
#include <string>
#include "base/command_line.h"
+#include "base/debug/activity_tracker.h"
+#include "base/feature_list.h"
#include "base/metrics/field_trial.h"
+#include "base/path_service.h"
#include "chrome/browser/prerender/prerender_field_trial.h"
+#include "chrome/common/chrome_paths.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/variations/variations_util.h"
#include "components/variations/variations_associated_data.h"
@@ -18,6 +22,10 @@ namespace chrome {
namespace {
+const base::Feature kStabilityDebuggingFeature{
+ "StabilityDebugging", base::FEATURE_DISABLED_BY_DEFAULT
+};
+
void SetupStunProbeTrial() {
#if defined(ENABLE_WEBRTC)
std::map<std::string, std::string> params;
@@ -39,11 +47,34 @@ void SetupStunProbeTrial() {
#endif
}
+void SetupStabilityDebugging() {
+ if (!base::FeatureList::IsEnabled(kStabilityDebuggingFeature))
+ return;
+
+ // TODO(bcwhite): Adjust these numbers once there is real data to show
+ // just how much of an arena is necessary.
+ const size_t kMemorySize = 1 << 20; // 1 MiB
+ const int kStackDepth = 4;
+ const uint64_t kAllocatorId = 0;
+
+ // Track code activities (such as posting task, blocking on locks, and
+ // joining threads) that can cause hanging threads and general instability.
+ base::FilePath user_data_dir;
+ bool success = base::PathService::Get(chrome::DIR_USER_DATA, &user_data_dir);
+ DCHECK(success);
+ base::debug::GlobalActivityTracker::CreateWithFile(
+ user_data_dir
+ .AppendASCII("StabilityDebugInfo")
+ .AddExtension(base::PersistentMemoryAllocator::kFileExtension),
+ kMemorySize, kAllocatorId, kStabilityDebuggingFeature.name, kStackDepth);
+}
+
} // namespace
void SetupDesktopFieldTrials(const base::CommandLine& parsed_command_line) {
prerender::ConfigurePrerender(parsed_command_line);
SetupStunProbeTrial();
+ SetupStabilityDebugging();
}
} // namespace chrome
« no previous file with comments | « base/threading/platform_thread_win.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698