Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1430)

Side by Side Diff: base/threading/platform_thread_win.cc

Issue 1980743002: Track thread activities in order to diagnose hangs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@readwrite-mmf
Patch Set: addressed review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/threading/platform_thread.h" 5 #include "base/threading/platform_thread.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include "base/debug/activity_tracker.h"
9 #include "base/debug/alias.h" 10 #include "base/debug/alias.h"
10 #include "base/debug/profiler.h" 11 #include "base/debug/profiler.h"
11 #include "base/logging.h" 12 #include "base/logging.h"
12 #include "base/threading/thread_id_name_manager.h" 13 #include "base/threading/thread_id_name_manager.h"
13 #include "base/threading/thread_restrictions.h" 14 #include "base/threading/thread_restrictions.h"
14 #include "base/tracked_objects.h" 15 #include "base/tracked_objects.h"
15 #include "base/win/scoped_handle.h" 16 #include "base/win/scoped_handle.h"
16 17
17 namespace base { 18 namespace base {
18 19
(...skipping 176 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 } 196 }
196 197
197 // static 198 // static
198 bool PlatformThread::CreateNonJoinable(size_t stack_size, Delegate* delegate) { 199 bool PlatformThread::CreateNonJoinable(size_t stack_size, Delegate* delegate) {
199 return CreateThreadInternal(stack_size, delegate, nullptr, 200 return CreateThreadInternal(stack_size, delegate, nullptr,
200 ThreadPriority::NORMAL); 201 ThreadPriority::NORMAL);
201 } 202 }
202 203
203 // static 204 // static
204 void PlatformThread::Join(PlatformThreadHandle thread_handle) { 205 void PlatformThread::Join(PlatformThreadHandle thread_handle) {
206 // Record the event that this thread is blocking upon (for hang diagnosis).
207 base::debug::ScopedThreadJoinActivity thread_activity(&thread_handle);
208
205 DCHECK(thread_handle.platform_handle()); 209 DCHECK(thread_handle.platform_handle());
206 // TODO(willchan): Enable this check once I can get it to work for Windows 210 // TODO(willchan): Enable this check once I can get it to work for Windows
207 // shutdown. 211 // shutdown.
208 // Joining another thread may block the current thread for a long time, since 212 // Joining another thread may block the current thread for a long time, since
209 // the thread referred to by |thread_handle| may still be running long-lived / 213 // the thread referred to by |thread_handle| may still be running long-lived /
210 // blocking tasks. 214 // blocking tasks.
211 #if 0 215 #if 0
212 base::ThreadRestrictions::AssertIOAllowed(); 216 base::ThreadRestrictions::AssertIOAllowed();
213 #endif 217 #endif
214 218
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 return ThreadPriority::REALTIME_AUDIO; 279 return ThreadPriority::REALTIME_AUDIO;
276 case THREAD_PRIORITY_ERROR_RETURN: 280 case THREAD_PRIORITY_ERROR_RETURN:
277 DPCHECK(false) << "GetThreadPriority error"; // Falls through. 281 DPCHECK(false) << "GetThreadPriority error"; // Falls through.
278 default: 282 default:
279 NOTREACHED() << "Unexpected priority: " << priority; 283 NOTREACHED() << "Unexpected priority: " << priority;
280 return ThreadPriority::NORMAL; 284 return ThreadPriority::NORMAL;
281 } 285 }
282 } 286 }
283 287
284 } // namespace base 288 } // namespace base
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698