Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Issue 198073004: Delete socket connection after debugger input loop ends. (Closed)

Created:
6 years, 9 months ago by Yang
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Delete socket connection after debugger input loop ends. R=svenpanne@chromium.org BUG=v8:3193 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19991

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/d8-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 9 months ago (2014-03-17 13:26:12 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-17 13:30:21 UTC) #2
Yang
6 years, 9 months ago (2014-03-17 13:32:08 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19991 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698