Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1980703003: Refactor DisassemblerWin32X86 and DisassemblerWin32X64 similarities into a base class DisassemblerW… (Closed)

Created:
4 years, 7 months ago by etiennep
Modified:
4 years, 7 months ago
Reviewers:
huangs, Will Harris
CC:
chromium-reviews, wfh+watch_chromium.org, huangs+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor DisassemblerWin32X86 and DisassemblerWin32X64 similarities into a base class DisassemblerWin This is a first attempt to merge similarities between DisassemblerWin32X86 and DisassemblerWin32X64 in a naive way. This includes creation of the base class and merging of nearly identical function. BUG= Committed: https://crrev.com/5ac34c9f0bbd8f8b3c9030a667420fa04d4d8fee Cr-Commit-Position: refs/heads/master@{#395079}

Patch Set 1 #

Patch Set 2 : Add new files to gyp #

Total comments: 20

Patch Set 3 : Merge ParseFileRegion and abolish some wrong-architecture check in unittests #

Patch Set 4 : Remove derived ParseFileRegionBody #

Patch Set 5 : Renaming disassembler_win for disassembler_win32 to make it work on other platforms #

Patch Set 6 : Inject is_PE32_plus_ and offset_of_data_directories_ as constants from derived classes #

Patch Set 7 : Change disassemblerWin32 member initialization order to suppress warning #

Total comments: 28

Patch Set 8 : Apply corrections #

Total comments: 16

Patch Set 9 : Add override keyword to destuctor #

Patch Set 10 : Some NIT corrections #

Total comments: 16

Patch Set 11 : Running cl format and correcting NITs #

Patch Set 12 : Removing redondant stddef.h and replacing bool initialization from 0 to false #

Patch Set 13 : Sync #

Patch Set 14 : Sync and fix conflicts #

Total comments: 4

Patch Set 15 : Correct formating #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -1746 lines) Patch
M courgette/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
M courgette/courgette.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +2 lines, -0 lines 0 comments Download
A + courgette/disassembler_win32.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 6 chunks +38 lines, -38 lines 0 comments Download
A + courgette/disassembler_win32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 30 chunks +104 lines, -164 lines 0 comments Download
M courgette/disassembler_win32_x64.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +12 lines, -109 lines 0 comments Download
M courgette/disassembler_win32_x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -650 lines 0 comments Download
M courgette/disassembler_win32_x64_unittest.cc View 1 2 3 4 5 6 7 5 chunks +3 lines, -10 lines 0 comments Download
M courgette/disassembler_win32_x86.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +13 lines, -110 lines 0 comments Download
M courgette/disassembler_win32_x86.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 3 chunks +4 lines, -655 lines 0 comments Download
M courgette/disassembler_win32_x86_unittest.cc View 1 2 3 4 5 6 7 5 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 56 (23 generated)
etiennep
PTAL
4 years, 7 months ago (2016-05-13 19:10:19 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/1
4 years, 7 months ago (2016-05-13 19:10:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/20001
4 years, 7 months ago (2016-05-13 19:30:30 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/5301) ios-device-gn on ...
4 years, 7 months ago (2016-05-13 19:37:55 UTC) #8
huangs
First round. https://chromiumcodereview.appspot.com/1980703003/diff/20001/courgette/disassembler_win.cc File courgette/disassembler_win.cc (right): https://chromiumcodereview.appspot.com/1980703003/diff/20001/courgette/disassembler_win.cc#newcode311 courgette/disassembler_win.cc:311: // Skip the relocs that live outside ...
4 years, 7 months ago (2016-05-13 20:12:21 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/40001
4 years, 7 months ago (2016-05-16 20:52:17 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/66739) chromeos_daisy_chromium_compile_only_ng on ...
4 years, 7 months ago (2016-05-16 21:03:05 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/60001
4 years, 7 months ago (2016-05-17 14:24:35 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/6797)
4 years, 7 months ago (2016-05-17 14:30:37 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/80001
4 years, 7 months ago (2016-05-17 15:27:58 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/100001
4 years, 7 months ago (2016-05-17 16:10:10 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/builds/6867)
4 years, 7 months ago (2016-05-17 16:16:03 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/120001
4 years, 7 months ago (2016-05-17 17:16:51 UTC) #25
etiennep
PTAnL https://chromiumcodereview.appspot.com/1980703003/diff/20001/courgette/disassembler_win.cc File courgette/disassembler_win.cc (right): https://chromiumcodereview.appspot.com/1980703003/diff/20001/courgette/disassembler_win.cc#newcode311 courgette/disassembler_win.cc:311: // Skip the relocs that live outside of ...
4 years, 7 months ago (2016-05-17 17:20:50 UTC) #26
huangs
More comments. https://chromiumcodereview.appspot.com/1980703003/diff/120001/courgette/disassembler_win32.cc File courgette/disassembler_win32.cc (right): https://chromiumcodereview.appspot.com/1980703003/diff/120001/courgette/disassembler_win32.cc#newcode472 courgette/disassembler_win32.cc:472: int address_width = AddressWidth(); const int kAddressWidth ...
4 years, 7 months ago (2016-05-17 17:53:12 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/140001
4 years, 7 months ago (2016-05-17 18:27:36 UTC) #29
etiennep
PTAnL! https://chromiumcodereview.appspot.com/1980703003/diff/120001/courgette/disassembler_win32.cc File courgette/disassembler_win32.cc (right): https://chromiumcodereview.appspot.com/1980703003/diff/120001/courgette/disassembler_win32.cc#newcode472 courgette/disassembler_win32.cc:472: int address_width = AddressWidth(); On 2016/05/17 17:53:11, huangs ...
4 years, 7 months ago (2016-05-17 18:30:11 UTC) #30
huangs
Only NITS. Please test: - Courgette-gen with production data produces identical result as before. - ...
4 years, 7 months ago (2016-05-17 19:44:34 UTC) #31
etiennep
I ran gen and apply on for x86 and x64 so far. You can take ...
4 years, 7 months ago (2016-05-17 21:35:13 UTC) #32
huangs
LGTM with NITs. Please run "git cl format" again. Thanks! https://chromiumcodereview.appspot.com/1980703003/diff/180001/courgette/disassembler_win32.cc File courgette/disassembler_win32.cc (right): https://chromiumcodereview.appspot.com/1980703003/diff/180001/courgette/disassembler_win32.cc#newcode7 ...
4 years, 7 months ago (2016-05-17 22:12:58 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/200001
4 years, 7 months ago (2016-05-18 15:03:30 UTC) #35
etiennep
Got LGTM from Samuel, but it would be great to have Will taking a look ...
4 years, 7 months ago (2016-05-18 15:12:16 UTC) #37
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-18 16:00:22 UTC) #39
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/220001
4 years, 7 months ago (2016-05-18 16:53:44 UTC) #41
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/7798)
4 years, 7 months ago (2016-05-18 16:58:35 UTC) #43
etiennep
Ping wfh@ PTAL.
4 years, 7 months ago (2016-05-19 17:21:28 UTC) #44
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/260001
4 years, 7 months ago (2016-05-19 21:56:30 UTC) #46
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 23:38:53 UTC) #48
huangs
Thanks for merging this! Still LGTM, with a few nits. Please run full Courgette-gen and ...
4 years, 7 months ago (2016-05-20 05:59:09 UTC) #49
etiennep
Great, ready to go! https://chromiumcodereview.appspot.com/1980703003/diff/260001/courgette/disassembler_win32.cc File courgette/disassembler_win32.cc (right): https://chromiumcodereview.appspot.com/1980703003/diff/260001/courgette/disassembler_win32.cc#newcode350 courgette/disassembler_win32.cc:350: AssemblyProgram* program) { On 2016/05/20 ...
4 years, 7 months ago (2016-05-20 14:47:21 UTC) #50
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980703003/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980703003/280001
4 years, 7 months ago (2016-05-20 14:47:47 UTC) #53
commit-bot: I haz the power
Committed patchset #15 (id:280001)
4 years, 7 months ago (2016-05-20 15:44:57 UTC) #54
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 15:47:42 UTC) #56
Message was sent while issue was closed.
Patchset 15 (id:??) landed as
https://crrev.com/5ac34c9f0bbd8f8b3c9030a667420fa04d4d8fee
Cr-Commit-Position: refs/heads/master@{#395079}

Powered by Google App Engine
This is Rietveld 408576698