Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 19807002: Turn on parallel recompilation for tests that assert optimization status. (Closed)

Created:
7 years, 5 months ago by Yang
Modified:
7 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Turn on parallel recompilation for tests that assert optimization status. R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=15793

Patch Set 1 #

Patch Set 2 : fix bogus assert #

Patch Set 3 : fix small details. no logic change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -184 lines) Patch
M src/runtime.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/runtime.cc View 1 2 2 chunks +13 lines, -23 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 2 chunks +4 lines, -4 lines 0 comments Download
M test/mjsunit/array-bounds-check-removal.js View 3 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 5 chunks +10 lines, -10 lines 0 comments Download
M test/mjsunit/array-feedback.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-literal-feedback.js View 2 chunks +3 lines, -3 lines 0 comments Download
M test/mjsunit/array-literal-transitions.js View 5 chunks +8 lines, -9 lines 0 comments Download
M test/mjsunit/array-natives-elements.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/assert-opt-and-deopt.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/compiler/parallel-proto-change.js View 2 chunks +7 lines, -8 lines 0 comments Download
M test/mjsunit/constant-folding-2.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/count-based-osr.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/date.js View 1 chunk +2 lines, -3 lines 0 comments Download
M test/mjsunit/debug-break-inline.js View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/deopt-minus-zero.js View 2 chunks +1 line, -14 lines 0 comments Download
M test/mjsunit/elements-transition-hoisting.js View 8 chunks +8 lines, -9 lines 0 comments Download
M test/mjsunit/harmony/block-let-crankshaft.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/manual-parallel-recompile.js View 2 chunks +4 lines, -15 lines 0 comments Download
M test/mjsunit/math-floor-of-div-minus-zero.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.js View 2 chunks +29 lines, -0 lines 0 comments Download
M test/mjsunit/never-optimize.js View 2 chunks +3 lines, -6 lines 0 comments Download
M test/mjsunit/parallel-initial-prototype-change.js View 2 chunks +7 lines, -8 lines 0 comments Download
M test/mjsunit/parallel-invalidate-transition-map.js View 2 chunks +7 lines, -11 lines 0 comments Download
M test/mjsunit/parallel-optimize-disabled.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-1118.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-2132.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-2250.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2315.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/regress/regress-2339.js View 2 chunks +1 line, -15 lines 0 comments Download
M test/mjsunit/regress/regress-2451.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/regress/regress-252797.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-2618.js View 2 chunks +2 lines, -3 lines 0 comments Download
M test/mjsunit/regress/regress-crbug-150545.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-embedded-cons-string.js View 1 chunk +11 lines, -9 lines 0 comments Download
M test/mjsunit/regress/regress-opt-after-debug-deopt.js View 2 chunks +3 lines, -2 lines 0 comments Download
M test/mjsunit/unbox-double-arrays.js View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
7 years, 5 months ago (2013-07-19 13:23:54 UTC) #1
mvstanton
That is a really nice cleanup. lgtm.
7 years, 5 months ago (2013-07-22 09:08:14 UTC) #2
Yang
7 years, 5 months ago (2013-07-22 09:16:51 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 manually as r15793 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698