Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1980693002: Upstream: Ignore android.util.Log usage in WebAPK code (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream: Ignore android.util.Log usage in WebAPK code Code in //chrome/android/webapk cannot depend on anything in Chromium including //base. Do not throw a PRESUMBIT error for android.util.Log usage in //chrome/android/webapk BUG=609122 Committed: https://crrev.com/a1dd0b00eb23baf4840bdfbbba153f6f7658b9b4 Cr-Commit-Position: refs/heads/master@{#393830}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M PRESUBMIT.py View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pkotwicz
phajdan.jr@ PTAL
4 years, 7 months ago (2016-05-13 18:37:57 UTC) #2
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-16 09:58:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980693002/1
4 years, 7 months ago (2016-05-16 14:10:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 14:41:14 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 14:43:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a1dd0b00eb23baf4840bdfbbba153f6f7658b9b4
Cr-Commit-Position: refs/heads/master@{#393830}

Powered by Google App Engine
This is Rietveld 408576698