Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1980673003: DevTools: fix screenshot size when emulated viewport is smaller than root view (Closed)

Created:
4 years, 7 months ago by caseq
Modified:
4 years, 7 months ago
Reviewers:
dgozman
CC:
chromium-reviews, darin-cc_chromium.org, jam, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix screenshot size when emulated viewport is smaller than root view BUG=611799 Committed: https://crrev.com/0026aed1b09b9d4d06da3ddc402e995bf57bfad8 Cr-Commit-Position: refs/heads/master@{#393709}

Patch Set 1 : simplified area calculation #

Total comments: 1

Patch Set 2 : changed to compute snapshot_size based on src_size #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -7 lines) Patch
M content/browser/devtools/devtools_frame_trace_recorder.cc View 1 1 chunk +13 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
caseq
4 years, 7 months ago (2016-05-13 22:13:39 UTC) #3
dgozman
lgtm https://codereview.chromium.org/1980673003/diff/20001/content/browser/devtools/devtools_frame_trace_recorder.cc File content/browser/devtools/devtools_frame_trace_recorder.cc (right): https://codereview.chromium.org/1980673003/diff/20001/content/browser/devtools/devtools_frame_trace_recorder.cc#newcode101 content/browser/devtools/devtools_frame_trace_recorder.cc:101: gfx::Size snapshot_size(gfx::ToRoundedSize(gfx::ScaleSize( Looks to be equal to src_size, ...
4 years, 7 months ago (2016-05-13 22:55:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980673003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980673003/40001
4 years, 7 months ago (2016-05-13 23:38:51 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-14 00:47:02 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-14 00:48:29 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/0026aed1b09b9d4d06da3ddc402e995bf57bfad8
Cr-Commit-Position: refs/heads/master@{#393709}

Powered by Google App Engine
This is Rietveld 408576698