Make json-maps implement Map<String, dynamic>.

Make json-maps implement Map<String, dynamic>.

Fixes #26407.
http://dartbug.com/26407

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/f6020b6d7eeed94239a1d686e3056db9b1f70a39

[floitsch, 2016-05-13 18:13:14]

Description was changed from

==========
Make json-maps implement Map<String, dynamic>.

Fixes #26407.
==========

to

==========
Make json-maps implement Map<String, dynamic>.

Fixes #26407.
http://dartbug.com/26407
==========

[floitsch, 2016-05-13 18:37:30]

floitsch@google.com changed reviewers:
+ lrn@google.com, sra@google.com

[floitsch, 2016-05-13 18:37:31]

Wdyt?
We went through great trouble to ensure that the json-map was writable and
accepted all kinds of keys. Should we change that to make it easier to type?

(see the linked issue).

[Lasse Reichstein Nielsen, 2016-05-17 07:03:05]

It's a potentially breaking change - if someone actually uses the JSON-parsed
map to store integer keys.
LGTM!

https://codereview.chromium.org/1980663002/diff/40001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/convert_patch.dart (right):

https://codereview.chromium.org/1980663002/diff/40001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/convert_patch.dart:127: class _JsonMap
implements LinkedHashMap<String, dynamic> {
This "implements implemenetation-class-as-interface" is really a code smell.
It should just be "Map", and anybody who types a variable as "LinkedHashMap"
should get the error they deserve.
(I don't mind breaking code if the code is bad :)

[floitsch, 2016-05-18 13:40:58]

https://codereview.chromium.org/1980663002/diff/40001/sdk/lib/_internal/js_ru...
File sdk/lib/_internal/js_runtime/lib/convert_patch.dart (right):

https://codereview.chromium.org/1980663002/diff/40001/sdk/lib/_internal/js_ru...
sdk/lib/_internal/js_runtime/lib/convert_patch.dart:127: class _JsonMap
implements LinkedHashMap<String, dynamic> {
On 2016/05/17 07:03:04, Lasse Reichstein Nielsen wrote:
> This "implements implemenetation-class-as-interface" is really a code smell.
> It should just be "Map", and anybody who types a variable as "LinkedHashMap"
> should get the error they deserve.
> (I don't mind breaking code if the code is bad :)

Done.

[floitsch, 2017-05-02 12:51:38]

Description was changed from

==========
Make json-maps implement Map<String, dynamic>.

Fixes #26407.
http://dartbug.com/26407
==========

to

==========
Make json-maps implement Map<String, dynamic>.

Fixes #26407.
http://dartbug.com/26407

R=lrn@google.com

Committed:
https://github.com/dart-lang/sdk/commit/f6020b6d7eeed94239a1d686e3056db9b1f70a39
==========

[floitsch, 2017-05-02 12:51:39]

Committed patchset #6 (id:100001) manually as
f6020b6d7eeed94239a1d686e3056db9b1f70a39 (presubmit successful).

[Lasse Reichstein Nielsen, 2017-05-02 15:02:41]

lgtm