Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 1980633002: Remove unused routing ID param from Did(Show|Destroy)FullscreenWidget. (Closed)

Created:
4 years, 7 months ago by alexmos
Modified:
4 years, 7 months ago
Reviewers:
ncarter (slow), miu
CC:
chromium-reviews, extensions-reviews_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, tfarina, nasko+codewatch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, chromium-apps-reviews_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused routing ID param from Did(Show|Destroy)FullscreenWidget. Looks like this was introduced in https://chromiumcodereview.appspot.com/12026029, where the routing IDs were used in web_contents_video_capture_device.cc coupled with the process ID from WebContents (i.e., main frame's process), but this has since been removed, and the routing IDs aren't currently used in any observers. With out-of-process iframes, this routing ID should really be coupled with process ID to be meaningful, but since nobody is using it, just remove the parameter. BUG=593522 Committed: https://crrev.com/899e06f316b1e9353b59a28e88f80796ad1b3d3b Cr-Commit-Position: refs/heads/master@{#393677}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -19 lines) Patch
M chrome/browser/extensions/api/tab_capture/offscreen_tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/offscreen_tab.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_registry.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/media/capture/web_contents_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
alexmos
Yuri, can you please take a look at whether this makes sense?
4 years, 7 months ago (2016-05-13 18:01:33 UTC) #3
miu
lgtm
4 years, 7 months ago (2016-05-13 22:44:33 UTC) #4
alexmos
Nick, can you please review content/ for OWNERS?
4 years, 7 months ago (2016-05-13 22:57:44 UTC) #6
ncarter (slow)
lgtm thanks for the cleanup!
4 years, 7 months ago (2016-05-13 23:00:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980633002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980633002/1
4 years, 7 months ago (2016-05-13 23:03:38 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 23:08:23 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 23:10:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/899e06f316b1e9353b59a28e88f80796ad1b3d3b
Cr-Commit-Position: refs/heads/master@{#393677}

Powered by Google App Engine
This is Rietveld 408576698