Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: platform_tools/android/tests/var_dict_tests.py

Issue 198063002: Updates to Android.mk generation. (Closed) Base URL: https://skia.googlesource.com/skia.git@android_mk
Patch Set: Add a comment explaining the motivation of OrderedSet. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « platform_tools/android/tests/utils.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/tests/var_dict_tests.py
diff --git a/platform_tools/android/tests/var_dict_tests.py b/platform_tools/android/tests/var_dict_tests.py
index 8cd96770682cfc30d9c38c22d5fbfe9a206c559a..94f0492b6f074ce93591a965922ad4a0d463526c 100644
--- a/platform_tools/android/tests/var_dict_tests.py
+++ b/platform_tools/android/tests/var_dict_tests.py
@@ -60,29 +60,9 @@ class VarsDictTest(unittest.TestCase):
for i in range(RANGE):
v_dict = VarsDict()
# Add something common to each field, as well as a unique entry
- v_dict.LOCAL_CFLAGS.add('cflag')
- v_dict.LOCAL_CFLAGS.add(str(i))
-
- v_dict.LOCAL_CPPFLAGS.add('cppflag')
- v_dict.LOCAL_CPPFLAGS.add(str(i))
-
- v_dict.LOCAL_SRC_FILES.add('src')
- v_dict.LOCAL_SRC_FILES.add(str(i))
-
- v_dict.LOCAL_SHARED_LIBRARIES.add('shared')
- v_dict.LOCAL_SHARED_LIBRARIES.add(str(i))
-
- v_dict.LOCAL_STATIC_LIBRARIES.add('static')
- v_dict.LOCAL_STATIC_LIBRARIES.add(str(i))
-
- v_dict.LOCAL_C_INCLUDES.add('includes')
- v_dict.LOCAL_C_INCLUDES.add(str(i))
-
- v_dict.LOCAL_EXPORT_C_INCLUDE_DIRS.add('exports')
- v_dict.LOCAL_EXPORT_C_INCLUDE_DIRS.add(str(i))
-
- v_dict.KNOWN_TARGETS.add('known')
- v_dict.KNOWN_TARGETS.add(str(i))
+ for key in v_dict.keys():
+ v_dict[key].add(key.lower())
+ v_dict[key].add(str(i))
self.assert_consistency(v_dict)
« no previous file with comments | « platform_tools/android/tests/utils.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698