platform_tools/android/gyp_gen/gypd_parser.py - Issue 198063002: Updates to Android.mk generation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: platform_tools/android/gyp_gen/gypd_parser.py

Issue 198063002: Updates to Android.mk generation. (Closed) Base URL: https://skia.googlesource.com/skia.git@android_mk

Patch Set: Add a comment explaining the motivation of OrderedSet. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: platform_tools/android/gyp_gen/gypd_parser.py

diff --git a/platform_tools/android/gyp_gen/gypd_parser.py b/platform_tools/android/gyp_gen/gypd_parser.py

index b547c42525c298ccce5f0a1655c058cdb571ebf7..fc4dc68e96a5894c0e167cdab27163343af57a52 100644

--- a/platform_tools/android/gyp_gen/gypd_parser.py

+++ b/platform_tools/android/gyp_gen/gypd_parser.py

@@ -9,8 +9,6 @@

Functions for parsing the gypd output from gyp.

"""

-import vars_dict_lib

def parse_dictionary(var_dict, d, current_target_name):

"""

Helper function to get the meaningful entries in a dictionary.

@@ -89,7 +87,7 @@ def parse_dictionary(var_dict, d, current_target_name):

var_dict.LOCAL_EXPORT_C_INCLUDE_DIRS.add(include)

for define in d.get('defines', []):

- var_dict.LOCAL_CFLAGS.add('-D' + define)

+ var_dict.DEFINES.add(define)

def parse_gypd(var_dict, path, desired_targets=None):