Updates to Android.mk generation.

gyp/common.gypi

 # Copyright 2011 The Android Open Source Project
 #
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 # This file is automatically included by gyp_skia when building any target.
 
 {
   'includes': [
     'common_variables.gypi',
@@ skipping 70 matching lines @@
           ],
         },
       }],
       [ 'skia_win_debuggers_path and skia_os == "win"',
         {
           'defines': [
             'SK_USE_CDB',
           ],
         },
       ],
-      [ 'skia_android_framework==0', {
+      [ 'skia_android_framework', {
+        'defines!': [
+          'SK_SCALAR_TO_FLOAT_EXCLUDED',

[djsollen, 2014/03/26 20:17:03]

why do we need to call this out here?  Won't we need this for now if the WebView
wanted to use the system copy of Skia?

[scroggo, 2014/03/27 19:33:00]

Removed.

[scroggo, 2014/03/28 17:39:28]

It turns out we *do* need this here*. All the negatives are confusing, but
here's how it works:

If you define this flag, SkFloatToScalar is not defined.

Android still uses SkFloatToScalar:
https://cs.corp.google.com/#search/&q=skfloattoscalar&sq=package:android

Here I'm changing it so we do *not* define this flag, meaning that
SkFloatToScalar *is* defined.

Defining SkFloatToScalar will not interfere with building WebView.

*Until we stop calling SkFloatToScalar in frameworks/base.

+        ],
+      }, {
         # These defines are not used for skia_android_framework, where we build
         # one makefile and allow someone to add SK_DEBUG etc for their own
         # debugging purposes.
         'configurations': {
           'Debug': {
             'defines': [
               'SK_DEBUG',
               'SK_DEVELOPER=1',
             ],
           },
           'Release': {
             'defines': [
               'SK_RELEASE',
             ],
           },
           'Release_Developer': {
             'inherit_from': ['Release'],
             'defines': [
               'SK_DEVELOPER=1',
             ],
           },
         },
       }],
     ],
   }, # end 'target_defaults'
 }