Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 1980623003: Update offline pages UMAs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
index f818cf64c8cd76c578e390e6ca70bdb5b980c2f4..f5e6c796f4d9c7d3eb8467f63afd1d6e3febda74 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc
@@ -53,6 +53,9 @@ void OfflinePageTabHelper::DidStartNavigation(
// immediate redirection to offline copy.
redirect_url = offline_pages::OfflinePageUtils::GetOfflineURLForOnlineURL(
web_contents()->GetBrowserContext(), navigation_handle->GetURL());
+
+ UMA_HISTOGRAM_BOOLEAN("OfflinePages.ShowOfflinePageWhenOffline",
fgorski 2016/05/16 16:20:04 can we report with suffix here? It would be intere
jianli 2016/05/16 22:35:25 I thought about this but we can't do it because no
+ redirect_url.is_valid());
} else {
// When the network is connected, loading offline copy will result in
// immediate redirection to online page.
« no previous file with comments | « no previous file | components/offline_pages/offline_page_model.h » ('j') | components/offline_pages/offline_page_model.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698