Update offline pages UMAs

chrome/browser/android/offline_pages/offline_page_tab_helper.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/offline_pages/offline_page_tab_helper.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/metrics/histogram.h"
 #include "base/thread_task_runner_handle.h"
@@ skipping 71 matching lines @@
     content::NavigationHandle* navigation_handle) {
   // Skips non-main frame.
   if (!navigation_handle->IsInMainFrame())
     return;
 
   // If the offline page is being loaded successfully, set the access record.
   net::Error error_code = navigation_handle->GetNetErrorCode();
   if (error_code == net::OK &&
       OfflinePageUtils::IsOfflinePage(
           web_contents()->GetBrowserContext(), navigation_handle->GetURL())) {
+    UMA_HISTOGRAM_BOOLEAN("OfflinePages.ShowOfflinePageWhenOffline", true);

[fgorski, 2016/05/17 03:53:23]

nit: this is a bit forward looking and perhaps we want to handle it differently
once NQE is available, but did you consider a case where we are not exactly
offline? E.g. Because NQE told us to. Will this name still work? Or will we
define a new UMA?

     OfflinePageUtils::MarkPageAccessed(
         web_contents()->GetBrowserContext(), navigation_handle->GetURL());
   }
 
   // Skips load failure other than no network.
   if (error_code != net::ERR_INTERNET_DISCONNECTED &&
       error_code != net::ERR_NAME_NOT_RESOLVED &&
       error_code != net::ERR_ADDRESS_UNREACHABLE &&
       error_code != net::ERR_PROXY_CONNECTION_FAILED) {
     return;
   }
 
   // On a forward or back transition, don't affect the order of the nav stack.
   if (navigation_handle->GetPageTransition() ==
       ui::PAGE_TRANSITION_FORWARD_BACK) {
+    UMA_HISTOGRAM_BOOLEAN("OfflinePages.ShowOfflinePageWhenOffline", false);
     return;
   }
 
   // When the navigation starts, we redirect immediately from online page to
   // offline version on the case that there is no network connection. If there
   // is still network connection but with no or poor network connectivity, the
   // navigation will eventually fail and we want to redirect to offline copy
   // in this case.
   GURL offline_url = offline_pages::OfflinePageUtils::GetOfflineURLForOnlineURL(
       web_contents()->GetBrowserContext(), navigation_handle->GetURL());
-  if (!offline_url.is_valid())
+  if (!offline_url.is_valid()) {
+    UMA_HISTOGRAM_BOOLEAN("OfflinePages.ShowOfflinePageWhenOffline", false);
     return;
+  }
 
   base::ThreadTaskRunnerHandle::Get()->PostTask(
       FROM_HERE,
       base::Bind(&OfflinePageTabHelper::Redirect,
                  weak_ptr_factory_.GetWeakPtr(),
                  navigation_handle->GetURL(), offline_url));
 }
 
 void OfflinePageTabHelper::Redirect(
     const GURL& from_url, const GURL& to_url) {
   if (to_url.SchemeIsFile()) {
     UMA_HISTOGRAM_COUNTS("OfflinePages.RedirectToOfflineCount", 1);
   } else {
     UMA_HISTOGRAM_COUNTS("OfflinePages.RedirectToOnlineCount", 1);
   }
 
   content::NavigationController::LoadURLParams load_params(to_url);
   load_params.transition_type = ui::PAGE_TRANSITION_CLIENT_REDIRECT;
   load_params.redirect_chain.push_back(from_url);
   web_contents()->GetController().LoadURLWithParams(load_params);
 }
 
 }  // namespace offline_pages