third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp - Issue 1980533002: CSP: Fix handling of nonces in report-only mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

Issue 1980533002: CSP: Fix handling of nonces in report-only mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: estark@ Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

diff --git a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

index fe575896efffb5469457394e81b7d2f1ac394a47..7f26963bff9bab4b99ae60c09edf8c4442c0e808 100644

--- a/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

+++ b/third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp

@@ -122,7 +122,7 @@ bool CSPDirectiveList::checkInline(SourceListDirective* directive) const

bool CSPDirectiveList::checkNonce(SourceListDirective* directive, const String& nonce) const

{

- return !directive || directive->allowNonce(nonce);

+ return directive && directive->allowNonce(nonce);

}

bool CSPDirectiveList::checkHash(SourceListDirective* directive, const CSPHashValue& hashValue) const