Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 198053002: Move ParseConditionalExpression to ParserBase. (Closed)

Created:
6 years, 9 months ago by marja
Modified:
6 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Move ParseConditionalExpression to ParserBase. R=mstarzinger@chromium.org BUG=v8:3126 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19994

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -50 lines) Patch
M src/parser.h View 1 2 chunks +1 line, -2 lines 0 comments Download
M src/parser.cc View 1 2 chunks +3 lines, -23 lines 0 comments Download
M src/preparser.h View 1 4 chunks +36 lines, -1 line 0 comments Download
M src/preparser.cc View 1 2 chunks +4 lines, -24 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
marja
rossberg, one more (this one is trivial, too), ptal
6 years, 9 months ago (2014-03-12 19:44:05 UTC) #1
marja
(reviewer swap, mstarzinger, ptal)
6 years, 9 months ago (2014-03-13 08:33:45 UTC) #2
Michael Starzinger
LGTM.
6 years, 9 months ago (2014-03-13 08:59:27 UTC) #3
marja
6 years, 9 months ago (2014-03-17 13:36:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r19994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698