Issue 19805003: Restore test and behavior prior to deferred stack trace formatting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19805003: Restore test and behavior prior to deferred stack trace formatting. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Restore test and behavior prior to deferred stack trace formatting. R=mstarzinger@chromium.org TEST=stack-traces-overflow.js Committed: https://code.google.com/p/v8/source/detail?r=15856

Patch Set 2 : comment addressed #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -202 lines)			Patch
M	src/messages.js	View	1	2 chunks	+39 lines, -36 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	src/runtime.cc	View		1 chunk	+6 lines, -35 lines	0 comments	Download
M	test/cctest/cctest.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		2 chunks	+34 lines, -3 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download
D	test/mjsunit/stack-traces-gc.js	View		1 chunk	+0 lines, -119 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM with one comment. https://codereview.chromium.org/19805003/diff/1/src/messages.js File src/messages.js (right): https://codereview.chromium.org/19805003/diff/1/src/messages.js#newcode1167 src/messages.js:1167: if (this == obj) { ...

7 years, 5 months ago (2013-07-24 12:07:40 UTC) #2

Yang

7 years, 5 months ago (2013-07-24 12:16:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15856 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19805003: Restore test and behavior prior to deferred stack trace formatting. (Closed)

Description

Patch Set 1 #

Patch Set 2 : comment addressed #

Messages