[es6] Reintroduce the instanceof operator in the backends.

[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=ishell@chromium.org
TBR=hpayer@chromium.org,rossberg@chromium.org
BUG=chromium:597249, v8:4447
LOG=n

Committed: https://crrev.com/551e0aa11bf4b97f9d38c4ce0c5aac89df0a773a
Cr-Commit-Position: refs/heads/master@{#36275}

[Igor Sheludko, 2016-05-17 08:40:30]

ishell@chromium.org changed reviewers:
+ ishell@chromium.org

[Igor Sheludko, 2016-05-17 08:40:32]

lgtm with nits modulo bytecode_expectations changes.

https://codereview.chromium.org/1980483003/diff/40001/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/1980483003/diff/40001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.cc:11688: if (function->has_initial_map() &&
Please copy respective comments from js-typed-lowering here.

https://codereview.chromium.org/1980483003/diff/40001/test/mjsunit/harmony/in...
File test/mjsunit/harmony/instanceof-es6.js (right):

https://codereview.chromium.org/1980483003/diff/40001/test/mjsunit/harmony/in...
test/mjsunit/harmony/instanceof-es6.js:64: F[Symbol.hasInstance] = function(v) {
return true };
How about increasing hasInstance invocation counter and checking that it's equal
to 1?

[Benedikt Meurer, 2016-05-17 10:23:21]

Addressed comments, thanks.

https://codereview.chromium.org/1980483003/diff/40001/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/1980483003/diff/40001/src/crankshaft/hydrogen...
src/crankshaft/hydrogen.cc:11688: if (function->has_initial_map() &&
On 2016/05/17 08:40:32, Igor Sheludko wrote:
> Please copy respective comments from js-typed-lowering here.

Done.

https://codereview.chromium.org/1980483003/diff/40001/test/mjsunit/harmony/in...
File test/mjsunit/harmony/instanceof-es6.js (right):

https://codereview.chromium.org/1980483003/diff/40001/test/mjsunit/harmony/in...
test/mjsunit/harmony/instanceof-es6.js:64: F[Symbol.hasInstance] = function(v) {
return true };
On 2016/05/17 08:40:32, Igor Sheludko wrote:
> How about increasing hasInstance invocation counter and checking that it's
equal
> to 1?

Done.

[Benedikt Meurer, 2016-05-17 10:38:26]

The CQ bit was checked by bmeurer@chromium.org

[Benedikt Meurer, 2016-05-17 10:38:27]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org
Link to the patchset: https://codereview.chromium.org/1980483003/#ps60001
(title: "Igors comments.")

[commit-bot: I haz the power, 2016-05-17 10:38:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980483003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980483003/60001

[commit-bot: I haz the power, 2016-05-17 10:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-17 10:44:49]

Try jobs failed on following builders:
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/15318)

[Benedikt Meurer, 2016-05-17 11:21:29]

Description was changed from

==========
[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=mstarzinger@chromium.org
BUG=chromium:597249, v8:4447
LOG=n
==========

to

==========
[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=ishell@chromium.org
TBR=hpayer@chromium.org,rossberg@chromium.org
BUG=chromium:597249, v8:4447
LOG=n
==========

[Benedikt Meurer, 2016-05-17 11:21:42]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-05-17 11:21:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980483003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980483003/60001

[commit-bot: I haz the power, 2016-05-17 11:24:09]

Description was changed from

==========
[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=ishell@chromium.org
TBR=hpayer@chromium.org,rossberg@chromium.org
BUG=chromium:597249, v8:4447
LOG=n
==========

to

==========
[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=ishell@chromium.org
TBR=hpayer@chromium.org,rossberg@chromium.org
BUG=chromium:597249, v8:4447
LOG=n
==========

[commit-bot: I haz the power, 2016-05-17 11:24:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-17 11:26:10]

Description was changed from

==========
[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=ishell@chromium.org
TBR=hpayer@chromium.org,rossberg@chromium.org
BUG=chromium:597249, v8:4447
LOG=n
==========

to

==========
[es6] Reintroduce the instanceof operator in the backends.

This adds back the instanceof operator support in the backends and
introduces a @@hasInstance protector cell on the isolate that guards the
fast path for the InstanceOfStub. This way we recover the ~10%
regression on Octane EarleyBoyer in Crankshaft and greatly improve
TurboFan and Ignition performance of instanceof.

R=ishell@chromium.org
TBR=hpayer@chromium.org,rossberg@chromium.org
BUG=chromium:597249, v8:4447
LOG=n

Committed: https://crrev.com/551e0aa11bf4b97f9d38c4ce0c5aac89df0a773a
Cr-Commit-Position: refs/heads/master@{#36275}
==========

[commit-bot: I haz the power, 2016-05-17 11:26:11]

Patchset 4 (id:??) landed as
https://crrev.com/551e0aa11bf4b97f9d38c4ce0c5aac89df0a773a
Cr-Commit-Position: refs/heads/master@{#36275}