Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1980463002: Fix %FunctionGetName and %_ClassOf for bound functions. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix %FunctionGetName and %_ClassOf for bound functions. R=bmeurer@chromium.org BUG=v8:5010 Committed: https://crrev.com/8e303dd0b3d5ded8c91f5982bc565c2edd8c511b Cr-Commit-Position: refs/heads/master@{#36276}

Patch Set 1 #

Patch Set 2 : also fix %ClassOf #

Patch Set 3 : fix %_ClassOf instead #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -44 lines) Patch
M src/crankshaft/arm/lithium-codegen-arm.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/arm64/lithium-codegen-arm64.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/ia32/lithium-codegen-ia32.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/crankshaft/x64/lithium-codegen-x64.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/runtime/runtime-function.cc View 2 1 chunk +11 lines, -3 lines 0 comments Download
M test/mjsunit/mirror-function.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-5010.js View 1 2 1 chunk +3 lines, -10 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980463002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980463002/1
4 years, 7 months ago (2016-05-13 11:08:48 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/1605) v8_linux64_avx2_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-13 11:27:41 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980463002/20001
4 years, 7 months ago (2016-05-13 12:00:28 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/1622) v8_mac_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-13 12:17:31 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980463002/40001
4 years, 7 months ago (2016-05-17 08:41:14 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-17 09:20:26 UTC) #14
Yang
Please take a look.
4 years, 7 months ago (2016-05-17 11:15:04 UTC) #15
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-17 11:20:29 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980463002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980463002/40001
4 years, 7 months ago (2016-05-17 11:22:18 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-17 11:25:20 UTC) #20
commit-bot: I haz the power
4 years, 7 months ago (2016-05-17 11:26:18 UTC) #22
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8e303dd0b3d5ded8c91f5982bc565c2edd8c511b
Cr-Commit-Position: refs/heads/master@{#36276}

Powered by Google App Engine
This is Rietveld 408576698