Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1980383002: [turbofan] Kill type Guard nodes during effect/control linearization. (Closed)

Created:
4 years, 7 months ago by Benedikt Meurer
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Kill type Guard nodes during effect/control linearization. These guards are useless anyways once you make it throw the effect/control linearizer because all memory operations and calls are connected to the control and/or effect chain anyways afterwards. Drive-by-fix: Fail in the InstructionSelector if we ever see a Guard node. R=jarin@chromium.org BUG=chromium:612142 Committed: https://crrev.com/33e571ff4b8210161e20d2484650f64809287f72 Cr-Commit-Position: refs/heads/master@{#36302}

Patch Set 1 #

Patch Set 2 : For "reason" wasm requires Begin/FinishRegion ATM. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -10 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 chunks +0 lines, -9 lines 0 comments Download
A test/mjsunit/regress/regress-crbug-612142.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 7 months ago (2016-05-17 12:25:31 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the baby we cooked. Please take a look. Thanks, Benedikt
4 years, 7 months ago (2016-05-17 12:26:05 UTC) #2
Jarin
lgtm
4 years, 7 months ago (2016-05-17 12:29:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980383002/20001
4 years, 7 months ago (2016-05-18 05:09:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 05:36:59 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 05:38:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/33e571ff4b8210161e20d2484650f64809287f72
Cr-Commit-Position: refs/heads/master@{#36302}

Powered by Google App Engine
This is Rietveld 408576698