Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Issue 1980373004: Implement jump targets in for-in. (Closed)

Created:
4 years, 7 months ago by ahe
Modified:
4 years, 7 months ago
Reviewers:
kasperl
CC:
rasta-dart+reviews_googlegroups.com
Base URL:
git@github.com:dart-lang/rasta.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -58 lines) Patch
M lib/kernel_visitor.dart View 8 chunks +55 lines, -58 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
ahe
4 years, 7 months ago (2016-05-17 22:11:59 UTC) #2
kasperl
LGTM. https://codereview.chromium.org/1980373004/diff/1/lib/kernel_visitor.dart File lib/kernel_visitor.dart (right): https://codereview.chromium.org/1980373004/diff/1/lib/kernel_visitor.dart#newcode290 lib/kernel_visitor.dart:290: ir.Statement buildContinueTarget( This helper makes a big difference ...
4 years, 7 months ago (2016-05-19 14:13:30 UTC) #3
ahe
Thank you! https://codereview.chromium.org/1980373004/diff/1/lib/kernel_visitor.dart File lib/kernel_visitor.dart (right): https://codereview.chromium.org/1980373004/diff/1/lib/kernel_visitor.dart#newcode290 lib/kernel_visitor.dart:290: ir.Statement buildContinueTarget( On 2016/05/19 14:13:30, kasperl wrote: ...
4 years, 7 months ago (2016-05-19 18:41:46 UTC) #4
ahe
4 years, 7 months ago (2016-05-19 18:41:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac35c4c39df6f7b033584806484d08da4bc87d45 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698