Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1106)

Unified Diff: xfa/fwl/basewidget/fwl_comboboximp.cpp

Issue 1980293004: Pass objects instead of strings for undo/redo records. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: xfa/fwl/basewidget/fwl_comboboximp.cpp
diff --git a/xfa/fwl/basewidget/fwl_comboboximp.cpp b/xfa/fwl/basewidget/fwl_comboboximp.cpp
index 81c2fa75d3b1186e84a21d2f06f6313d812d35b7..b24f4132d601559fc990770e619b20287524ecb2 100644
--- a/xfa/fwl/basewidget/fwl_comboboximp.cpp
+++ b/xfa/fwl/basewidget/fwl_comboboximp.cpp
@@ -69,11 +69,11 @@ FWL_Error IFWL_ComboBox::SetEditLimit(int32_t nLimit) {
FWL_Error IFWL_ComboBox::EditDoClipboard(int32_t iCmd) {
return static_cast<CFWL_ComboBoxImp*>(GetImpl())->EditDoClipboard(iCmd);
}
-FX_BOOL IFWL_ComboBox::EditRedo(const CFX_ByteStringC& bsRecord) {
- return static_cast<CFWL_ComboBoxImp*>(GetImpl())->EditRedo(bsRecord);
+FX_BOOL IFWL_ComboBox::EditRedo(const IFDE_TxtEdtDoRecord* pRecord) {
+ return static_cast<CFWL_ComboBoxImp*>(GetImpl())->EditRedo(pRecord);
}
-FX_BOOL IFWL_ComboBox::EditUndo(const CFX_ByteStringC& bsRecord) {
- return static_cast<CFWL_ComboBoxImp*>(GetImpl())->EditUndo(bsRecord);
+FX_BOOL IFWL_ComboBox::EditUndo(const IFDE_TxtEdtDoRecord* pRecord) {
+ return static_cast<CFWL_ComboBoxImp*>(GetImpl())->EditUndo(pRecord);
}
IFWL_ListBox* IFWL_ComboBox::GetListBoxt() {
return static_cast<CFWL_ComboBoxImp*>(GetImpl())->GetListBoxt();
@@ -789,15 +789,15 @@ FWL_Error CFWL_ComboBoxImp::EditDoClipboard(int32_t iCmd) {
return FWL_Error::Indefinite;
return m_pEdit->DoClipboard(iCmd);
}
-FX_BOOL CFWL_ComboBoxImp::EditRedo(const CFX_ByteStringC& bsRecord) {
+FX_BOOL CFWL_ComboBoxImp::EditRedo(const IFDE_TxtEdtDoRecord* pRecord) {
if (!m_pEdit)
Tom Sepez 2016/05/17 20:37:59 nit: or just return m_pEdit && m_pEdit->Redo(pReco
dsinclair 2016/05/17 20:50:02 Done.
return FALSE;
- return m_pEdit->Redo(bsRecord);
+ return m_pEdit->Redo(pRecord);
}
-FX_BOOL CFWL_ComboBoxImp::EditUndo(const CFX_ByteStringC& bsRecord) {
+FX_BOOL CFWL_ComboBoxImp::EditUndo(const IFDE_TxtEdtDoRecord* pRecord) {
if (!m_pEdit)
return FALSE;
- return m_pEdit->Undo(bsRecord);
+ return m_pEdit->Undo(pRecord);
Tom Sepez 2016/05/17 20:37:59 same here.
dsinclair 2016/05/17 20:50:02 Done.
}
IFWL_ListBox* CFWL_ComboBoxImp::GetListBoxt() {
return m_pListBox.get();

Powered by Google App Engine
This is Rietveld 408576698