Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: xfa/fwl/lightwidget/cfwl_combobox.cpp

Issue 1980293004: Pass objects instead of strings for undo/redo records. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #include "xfa/fwl/lightwidget/cfwl_combobox.h" 7 #include "xfa/fwl/lightwidget/cfwl_combobox.h"
8 8
9 #include <utility> 9 #include <utility>
10 10
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 return FWL_Error::Indefinite; 133 return FWL_Error::Indefinite;
134 return static_cast<IFWL_ComboBox*>(m_pIface)->SetEditLimit(nLimit); 134 return static_cast<IFWL_ComboBox*>(m_pIface)->SetEditLimit(nLimit);
135 } 135 }
136 136
137 FWL_Error CFWL_ComboBox::EditDoClipboard(int32_t iCmd) { 137 FWL_Error CFWL_ComboBox::EditDoClipboard(int32_t iCmd) {
138 if (!m_pIface) 138 if (!m_pIface)
139 return FWL_Error::Indefinite; 139 return FWL_Error::Indefinite;
140 return static_cast<IFWL_ComboBox*>(m_pIface)->EditDoClipboard(iCmd); 140 return static_cast<IFWL_ComboBox*>(m_pIface)->EditDoClipboard(iCmd);
141 } 141 }
142 142
143 FX_BOOL CFWL_ComboBox::EditRedo(const CFX_ByteStringC& bsRecord) { 143 FX_BOOL CFWL_ComboBox::EditRedo(const IFDE_TxtEdtDoRecord* pRecord) {
144 if (!m_pIface) 144 if (!m_pIface)
145 return FALSE; 145 return FALSE;
146 return static_cast<IFWL_ComboBox*>(m_pIface)->EditRedo(bsRecord); 146 return static_cast<IFWL_ComboBox*>(m_pIface)->EditRedo(pRecord);
147 } 147 }
148 148
149 FX_BOOL CFWL_ComboBox::EditUndo(const CFX_ByteStringC& bsRecord) { 149 FX_BOOL CFWL_ComboBox::EditUndo(const IFDE_TxtEdtDoRecord* pRecord) {
150 if (!m_pIface) 150 if (!m_pIface)
151 return FALSE; 151 return FALSE;
152 return static_cast<IFWL_ComboBox*>(m_pIface)->EditUndo(bsRecord); 152 return static_cast<IFWL_ComboBox*>(m_pIface)->EditUndo(pRecord);
153 } 153 }
154 154
155 FWL_Error CFWL_ComboBox::SetMaxListHeight(FX_FLOAT fMaxHeight) { 155 FWL_Error CFWL_ComboBox::SetMaxListHeight(FX_FLOAT fMaxHeight) {
156 m_comboBoxData.m_fMaxListHeight = fMaxHeight; 156 m_comboBoxData.m_fMaxListHeight = fMaxHeight;
157 return FWL_Error::Succeeded; 157 return FWL_Error::Succeeded;
158 } 158 }
159 159
160 FWL_Error CFWL_ComboBox::SetItemData(int32_t iIndex, void* pData) { 160 FWL_Error CFWL_ComboBox::SetItemData(int32_t iIndex, void* pData) {
161 CFWL_ComboBoxItem* pItem = reinterpret_cast<CFWL_ComboBoxItem*>( 161 CFWL_ComboBoxItem* pItem = reinterpret_cast<CFWL_ComboBoxItem*>(
162 m_comboBoxData.GetItem(m_pIface, iIndex)); 162 m_comboBoxData.GetItem(m_pIface, iIndex));
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
424 FWL_HLISTITEM hItem, 424 FWL_HLISTITEM hItem,
425 uint32_t dwCheckState) { 425 uint32_t dwCheckState) {
426 CFWL_ComboBoxItem* pItem = reinterpret_cast<CFWL_ComboBoxItem*>(hItem); 426 CFWL_ComboBoxItem* pItem = reinterpret_cast<CFWL_ComboBoxItem*>(hItem);
427 pItem->m_dwCheckState = dwCheckState; 427 pItem->m_dwCheckState = dwCheckState;
428 return FWL_Error::Succeeded; 428 return FWL_Error::Succeeded;
429 } 429 }
430 430
431 FX_FLOAT CFWL_ComboBox::CFWL_ComboBoxDP::GetListHeight(IFWL_Widget* pWidget) { 431 FX_FLOAT CFWL_ComboBox::CFWL_ComboBoxDP::GetListHeight(IFWL_Widget* pWidget) {
432 return m_fMaxListHeight; 432 return m_fMaxListHeight;
433 } 433 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698