Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 1980283002: Revert of mus: Add views_mus_interactive_ui_tests target (Closed)

Created:
4 years, 7 months ago by James Cook
Modified:
4 years, 7 months ago
Reviewers:
Dirk Pranke, sadrul, sky
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mus: Add views_mus_interactive_ui_tests target (patchset #9 id:150001 of https://codereview.chromium.org/1972363002/ ) Reason for revert: Broke Chromium Win on Win x64 Builder (dbg) [3415/4254] CXX obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj FAILED: obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj ninja -t msvc -e environment.x64 -- C:\b\build\slave\cache\cipd\goma/gomacc.exe "C:\b\depot_tools\win_toolchain\vs_files\95ddda401ec5678f15eeed01d2bee08fcbc5ee97\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj.rsp /c ../../ui/views/widget/widget_interactive_uitest.cc /Foobj/ui/views/mus/views_mus_interactive_ui_tests/widget_interactive_uitest.obj /Fd"obj/ui/views/mus/views_mus_interactive_ui_tests_cc.pdb" c:\b\build\slave\win_x64_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc(658): error C2220: warning treated as error - no 'object' file generated c:\b\build\slave\win_x64_builder__dbg_\build\src\ui\views\widget\widget_interactive_uitest.cc(658): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data Original issue's description: > mus: Add views_mus_interactive_ui_tests target > > * Run widget_interactive_uitests.cc in the new target. > * Added a shared "test_support" target in ui/views/mus. > * Pull ViewsMusTestSuite into its own file so I can share it. > * Also make ViewsTestBase::IsMus static so I can call it before the > PlatformTestHelper is initialized. > * Disable a bunch of tests that fail on mus (I filed bugs for them). > > BUG=602036 > TEST=views_interactive_ui_tests on mus, interactive_ui_tests elsewhere > > Committed: https://crrev.com/94b68793a258e9261d1dc39cc5fdd2de673ec888 > Cr-Commit-Position: refs/heads/master@{#394026} TBR=sky@chromium.org,dpranke@chromium.org,sadrul@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=602036 Committed: https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69 Cr-Commit-Position: refs/heads/master@{#394033}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -390 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M testing/buildbot/chromium.linux.json View 1 chunk +0 lines, -6 lines 0 comments Download
M testing/buildbot/chromium.mojo.json View 2 chunks +0 lines, -6 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/BUILD.gn View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/mus/BUILD.gn View 5 chunks +20 lines, -89 lines 0 comments Download
M ui/views/mus/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D ui/views/mus/interactive_ui_tests_manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D ui/views/mus/interactive_ui_tests_mus.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/views/mus/run_all_unittests_mus.cc View 1 chunk +137 lines, -2 lines 0 comments Download
D ui/views/mus/views_mus_test_suite.h View 1 chunk +0 lines, -34 lines 0 comments Download
D ui/views/mus/views_mus_test_suite.cc View 1 chunk +0 lines, -142 lines 0 comments Download
M ui/views/run_all_unittests.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/run_all_unittests.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/test/platform_test_helper.h View 1 chunk +1 line, -4 lines 0 comments Download
M ui/views/test/platform_test_helper.cc View 2 chunks +2 lines, -11 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/test/scoped_views_test_helper.cc View 2 chunks +5 lines, -1 line 0 comments Download
M ui/views/test/views_test_base.h View 2 chunks +1 line, -3 lines 0 comments Download
M ui/views/test/views_test_base.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M ui/views/widget/widget_interactive_uitest.cc View 9 chunks +10 lines, -52 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
James Cook
Created Revert of mus: Add views_mus_interactive_ui_tests target
4 years, 7 months ago (2016-05-17 03:03:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1980283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1980283002/1
4 years, 7 months ago (2016-05-17 03:03:32 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-17 03:04:24 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bc8a6f1f97c20f232396d82396ee4524721c1a69 Cr-Commit-Position: refs/heads/master@{#394033}
4 years, 7 months ago (2016-05-17 03:05:49 UTC) #6
Dirk Pranke
4 years, 7 months ago (2016-05-17 03:10:24 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698