GPU test expectations: more precisely detect ANGLE

GPU test expectations: more precisely detect ANGLE

Previously we only looked at the "OpenGL", "Direct3D9" and "Direct3D11"
string in the GL_RENDERER to decide that we were using ANGLE. This
would incorrectly match OSX's "Intel Iris Pro OpenGL Engine" as ANGLE
with the OpenGL backend.

We now check that "ANGLE" appears in GL_RENDERER to match ANGLE. Also
adds a regression test and a unittest for the no_angle keyword.

BUG=612293
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9ef10b51b20d9d693d0484aad6f03951bac61e5c
Cr-Commit-Position: refs/heads/master@{#394249}

[cwallez, 2016-05-17 15:21:40]

Description was changed from

==========
GPU test expectations: more precisely detect ANGLE

Previously we only looked at the "OpenGL", "Direct3D9" and "Direct3D11"
string in the GL_RENDERER to decide that we were using ANGLE. This
would incorrectly match OSX's "Intel Iris Pro OpenGL Engine" as ANGLE
with the OpenGL backend.

We now check that "ANGLE" appears in GL_RENDERER to match ANGLE. Also
adds a regression test and a unittest for the no_angle keyword.

BUG=612293
==========

to

==========
GPU test expectations: more precisely detect ANGLE

Previously we only looked at the "OpenGL", "Direct3D9" and "Direct3D11"
string in the GL_RENDERER to decide that we were using ANGLE. This
would incorrectly match OSX's "Intel Iris Pro OpenGL Engine" as ANGLE
with the OpenGL backend.

We now check that "ANGLE" appears in GL_RENDERER to match ANGLE. Also
adds a regression test and a unittest for the no_angle keyword.

BUG=612293
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-05-17 15:22:36]

cwallez@chromium.org changed reviewers:
+ cwallez@chromium.org, kbr@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-05-17 15:22:36]

PTAL, this will fix the breakage on the mac bots due to no_angle

[Ken Russell (switch to Gerrit), 2016-05-17 19:03:41]

Excellent. LGTM

[Corentin Wallez, 2016-05-17 19:08:13]

On 2016/05/17 at 19:03:41, kbr wrote:
> Excellent. LGTM

Thanks!

[Corentin Wallez, 2016-05-17 19:08:16]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-05-17 19:08:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1980243004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1980243004/1

[commit-bot: I haz the power, 2016-05-17 22:40:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-17 22:41:48]

Description was changed from

==========
GPU test expectations: more precisely detect ANGLE

Previously we only looked at the "OpenGL", "Direct3D9" and "Direct3D11"
string in the GL_RENDERER to decide that we were using ANGLE. This
would incorrectly match OSX's "Intel Iris Pro OpenGL Engine" as ANGLE
with the OpenGL backend.

We now check that "ANGLE" appears in GL_RENDERER to match ANGLE. Also
adds a regression test and a unittest for the no_angle keyword.

BUG=612293
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
GPU test expectations: more precisely detect ANGLE

Previously we only looked at the "OpenGL", "Direct3D9" and "Direct3D11"
string in the GL_RENDERER to decide that we were using ANGLE. This
would incorrectly match OSX's "Intel Iris Pro OpenGL Engine" as ANGLE
with the OpenGL backend.

We now check that "ANGLE" appears in GL_RENDERER to match ANGLE. Also
adds a regression test and a unittest for the no_angle keyword.

BUG=612293
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/9ef10b51b20d9d693d0484aad6f03951bac61e5c
Cr-Commit-Position: refs/heads/master@{#394249}
==========

[commit-bot: I haz the power, 2016-05-17 22:41:49]

Patchset 1 (id:??) landed as
https://crrev.com/9ef10b51b20d9d693d0484aad6f03951bac61e5c
Cr-Commit-Position: refs/heads/master@{#394249}