Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: chrome/tools/build/mac/run_verify_order.py

Issue 1980173002: [Mac/GN] Add verify_order step for the Framework. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix comment Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/mac/run_verify_order.py
diff --git a/build/config/mac/xcrun.py b/chrome/tools/build/mac/run_verify_order.py
similarity index 55%
copy from build/config/mac/xcrun.py
copy to chrome/tools/build/mac/run_verify_order.py
index e2a775e51588bc58aea832544c35e2ef18cd5061..70802464393177ecbc8aa1c50b0768d3c062208d 100644
--- a/build/config/mac/xcrun.py
+++ b/chrome/tools/build/mac/run_verify_order.py
@@ -3,18 +3,25 @@
# found in the LICENSE file.
import argparse
-import os
-import subprocess
+import os.path
import sys
+import subprocess
+
+# Wraps chrome/tools/build/mac/verify_order for the GN build so that it can
+# write a stamp file, rather than operate as a postbuild.
if __name__ == '__main__':
parser = argparse.ArgumentParser(
- description='A script to execute a command via xcrun.')
+ description='A wrapper around verify_order that writes a stamp file.')
parser.add_argument('--stamp', action='store', type=str,
- help='Write a stamp file to this path on success.')
+ help='Touch this stamp file on success.')
+
args, unknown_args = parser.parse_known_args()
- rv = subprocess.check_call(['xcrun'] + unknown_args)
+ this_script_dir = os.path.dirname(sys.argv[0])
+ rv = subprocess.check_call(
+ [ os.path.join(this_script_dir, 'verify_order') ] + unknown_args)
+
if rv == 0 and args.stamp:
if os.path.exists(args.stamp):
os.unlink(args.stamp)
« no previous file with comments | « chrome/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698